Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splines linear problem 3x3 blocks #478

Merged
merged 36 commits into from
Jun 26, 2024
Merged

Conversation

blegouix
Copy link
Collaborator

@blegouix blegouix commented Jun 5, 2024

No description provided.

@blegouix blegouix self-assigned this Jun 5, 2024
@blegouix blegouix marked this pull request as draft June 5, 2024 10:57
@blegouix blegouix requested a review from tpadioleau June 5, 2024 11:40
@blegouix blegouix marked this pull request as ready for review June 5, 2024 11:40
@blegouix blegouix mentioned this pull request Jun 5, 2024
@tpadioleau
Copy link
Member

Do we need it in the end ?

@blegouix
Copy link
Collaborator Author

blegouix commented Jun 21, 2024

We never discussed to avoid this class, the discussion two weeks ago was about the periodic-specific class (which I did not reimplement).

@tpadioleau
Copy link
Member

We never discussed to avoid this class, the discussion two weeks ago was about the periodic-specific class (which I did not reimplement).

Ok my bad I mixed different things

Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only minor modifications

@tpadioleau tpadioleau merged commit 8f8dc8d into main Jun 26, 2024
49 checks passed
@tpadioleau tpadioleau deleted the splines-linear-problem-3x3-blocks branch June 26, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants