[WIP] CGAL 3D conforming constrained Delaunay triangulation

[lrineau]

Summary of Changes

This submission contributes 3D Constrained Delaunay triangulations to CGAL.

TODO list

Preview Give feedback

1. move all added files from Triangulation_3/ to CDT_3/:
2. check and fix the "Affected package" section, below
3. debug test debug_segment_traverser_in_2D.cpp that is failing

Release Management

• Affected package(s): new package, with a few modified packages (TBD...)

• Feature/Small Feature (if any): Features/3D Constrained Delaunay triangulations

• Link to compiled documentation: ref manual (wip), package overview (wip), missing user manual

• License and copyright ownership: GPLv3+, owned by GeometryFactory

[albert-github]

In the overnight documentation build for the 1.9.6 version I saw:

CDT_3_common_named_parameters.dox-frag:1: warning: Found unknown command '\cgalParamNBegin'
CDT_3_common_named_parameters.dox-frag:2: warning: Found unknown command '\cgalParamDescription'
CDT_3_common_named_parameters.dox-frag:3: warning: Found unknown command '\cgalParamType'
CDT_3_common_named_parameters.dox-frag:4: warning: Found unknown command '\cgalParamDefault'
CDT_3_common_named_parameters.dox-frag:5: warning: Found unknown command '\cgalParamNEnd'

it might be that adding the following

EXTENSION_MAPPING += dox-frag=md

will solve this for the 1.9.6 (and 1.8.13) version.
(the master version of doxygen is probably not having the problem as in the mean time some changes took place in handling the place of the \include{doc})

[afabri]

it might be that adding the following

EXTENSION_MAPPING += dox-frag=md

will solve this for the 1.9.6 (and 1.8.13) version. (the master version of doxygen is probably not having the problem as in the mean time some changes took place in handling the place of the \include{doc})

In which file?

[albert-github]

Documentation/doc/resources/1.9.6/BaseDoxyfile.in and Documentation/doc/resources/1.8.13/BaseDoxyfile.in

or alternatively in the Doxyfile.in of this project

[afabri]

At least for VC++, this static_assert(CGAL::is_nothrow_movable_v<CDT_3_impl>); still triggers an error.

[sloriot]

I already fixed doxygen

[albert-github]

@sloriot
In which commit did you fix doxygen?
as @afabri also made a commit: af1d9f5

[sloriot]

@sloriot In which commit did you fix doxygen? as @afabri also made a commit: af1d9f5

I got rid of the file and copied the 3 lines at the 3 places it was used.

[albert-github]

@sloriot when used in just one place it is probably the better solution., this also means that the fix from @afabri can be removed again.

[afabri]

Warning

     5>C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\ranges(11): warning STL4038: The contents of <ranges> are available only with C++20 or later. [C:\CGAL_ROOT\CGAL-6.1-Ic-87\cmake\platforms\MSVC-2022-Community-Release\test\Constrained_triangulation_3\test_constrained_Delaunay_triangulation_3.vcxproj]
     5>C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\format(42): warning STL4038: The contents of <format> are available only with C++20 or later. [C:\CGAL_ROOT\CGAL-6.1-Ic-87\cmake\platforms\MSVC-2022-Community-Release\test\Constrained_triangulation_3\test_constrained_Delaunay_triangulation_3.vcxproj]
     5>C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\concepts(12): warning STL4038: The contents of <concepts> are available only with C++20 or later. [C:\CGAL_ROOT\CGAL-6.1-Ic-87\cmake\platforms\MSVC-2022-Community-Release\test\Constrained_triangulation_3\test_constrained_Delaunay_triangulation_3.vcxproj]
     5>C:\CGAL_ROOT\CGAL-6.1-Ic-87\include\CGAL\Conforming_constrained_Delaunay_triangulation_3.h(3613,24): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [C:\CGAL_ROOT\CGAL-6.1-Ic-87\cmake\platforms\MSVC-2022-Community-Release\test\Constrained_triangulation_3\test_constrained_Delaunay_triangulation_3.vcxproj]
         (compiling source file '../../../../../test/Constrained_triangulation_3/test_constrained_Delaunay_triangulation_3.cpp')

here

[afabri]

Warning

/Users/magritte/cgal_root/CGAL-6.1-Ic-87/include/CGAL/Conforming_constrained_Delaunay_triangulation_3.h:782:10: warning: unused variable 'face_patch_map' [-Wunused-variable]
    auto face_patch_map = parameters::choose_parameter(parameters::get_parameter(np, internal_np::face_patch),

here