E-commerce Platforms and Integrations #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdark
reviewed
Feb 23, 2023
console/migrations/m230221_134343_add_shopify_mock_ecommerce_platfort.php
Outdated
Show resolved
Hide resolved
| use common\models\EcommercePlatform; | ||
|
|
||
| /** | ||
| * Class m230221_134343_add_shopify_mock_ecommerce_platfort |
There was a problem hiding this comment.
Suggested change
| * Class m230221_134343_add_shopify_mock_ecommerce_platfort | |
| * Class m230221_134343_add_shopify_mock_ecommerce_platform |
There was a problem hiding this comment.
@samdark thanks)
Comment on lines
16
to
18
| $ecommercePlatform = new EcommercePlatform(); | ||
| $ecommercePlatform->name = EcommercePlatform::SHOPIFY_PLATFORM_NAME; | ||
| $ecommercePlatform->save(); |
There was a problem hiding this comment.
I'd avoid using model in migration. Model may change and migration won't apply anymore.
There was a problem hiding this comment.
Totally agree. Changed.
…latfort.php Co-authored-by: Alexander Makarov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/ Old logic related to Shopify was deleted (DB tables, a separate Yii instance, code, docker, etc.)
2/ E-commerce Platforms.
Access: Only
admin.Adding: I suppose adding must be implemented via code (migrations) since it will be "system" objects in the future. I added Shopify as the first mock e-commerce platform.
Actions:
Fields:
Explanations:
3/ E-commerce Integrations. Depends on E-commerce Platforms.
Access: All
users.Actions:
Explanations:
E-commerce Platforms:
`
`
E-commerce Integrations:
`
`