fix(string): fix some bugs

please refer to the file change history for details
CLimber-Rong · Aug 21, 2024 · cbbed4e · cbbed4e
1 parent dd4521c
commit cbbed4e
Showing 1 changed file with 3 additions and 12 deletions.
diff --git a/include/stdc_implemented/String.hpp b/include/stdc_implemented/String.hpp
@@ -97,10 +97,7 @@ class String {
 		String toString(int value) {
 			StrFree();
 			str = (char_type*)StrCalloc(256);
-			if(sprintf(str, "%d", value) < 0) {
-				//如果出错就为-1
-				*this = String("-1");
-			}
+			snprintf(str, 256, "%d", value);
 			str = (char_type*)realloc(str, strlen(str)+1);
 			return String(str);
 		}
@@ -122,21 +119,15 @@ class String {
 		String toString(float value) {
 			StrFree();
 			str = (char_type*)StrCalloc(256);
-			if(sprintf(str, "%f", value) < 0) {
-				//如果出错就为-1
-				*this = String("-1");
-			}
+			snprintf(str, 256, "%f", value);
 			str = (char_type*)realloc(str, strlen(str)+1);
 			return String(str);
 		}
 
 		String toString(double value) {
 			StrFree();
 			str = (char_type*)StrCalloc(256);
-			if(sprintf(str, "%lf", value) < 0) {
-				//如果出错就为-1
-				*this = String("-1");
-			}
+			snprintf(str, 256, "%lf", value);
 			str = (char_type*)realloc(str, strlen(str)+1);
 			return String(str);
 		}