Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Navbar #11

Merged
merged 6 commits into from
Dec 21, 2022
Merged

[ADDED] Navbar #11

merged 6 commits into from
Dec 21, 2022

Conversation

atulyadav745
Copy link
Contributor

Responsive Navbar is added
Fixed issue #1

Copy link
Member

@king-11 king-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combine into a single component and use semantic html instead of just div

components/Navbar/NavLinks.tsx Outdated Show resolved Hide resolved
components/Navbar/NavLinks.tsx Outdated Show resolved Hide resolved
components/Navbar/Login.tsx Outdated Show resolved Hide resolved
components/Navbar/Navbar.tsx Outdated Show resolved Hide resolved
@atulyadav745
Copy link
Contributor Author

@king-11 Thanks Bhaiya. Great Review, hope I fixed it.
Screenshot (274)

Screenshot (275)
ng)
Screenshot (276)

@Divyansh013 Divyansh013 merged commit a63cdc9 into COPS-IITBHU:main Dec 21, 2022
@king-11
Copy link
Member

king-11 commented Dec 21, 2022

@Divyansh013 we can use the new layout feature maybe configure that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants