CI for ubuntu 22 and 24 #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vifactor
force-pushed
the
ubuntu-ci
branch
4 times, most recently
from
a92aa9d to
98e4680
Compare
Merged
hannesa2
requested changes
Nov 24, 2024
.github/workflows/BuildPR.yml
Outdated
| @@ -135,6 +135,23 @@ jobs: | |||
| name: DLTViewer-linux-x86_64 | |||
| path: build/dist/DLTViewer*.tgz | |||
|
|
|||
| buildNewerUbuntu: | |||
There was a problem hiding this comment.
e.g in the year 2028 the name buildNewerUbuntu is no more sufficient.
.github/workflows/BuildPR.yml
Outdated
| fetch-depth: 0 | ||
| submodules: true | ||
| - name: install build environment | ||
| run: scripts/linux/install_newer.sh |
.github/workflows/BuildPR.yml
Outdated
| - name: install build environment | ||
| run: scripts/linux/install_newer.sh | ||
| - name: Build project | ||
| run: scripts/linux/build_newer.sh |
|
I guess when qt6 works everywhere #405, we can drop Ubuntu 20 with qt5 |
Signed-off-by: Viktor Kopp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 20.04 approaching its EoL. This PR adds modern versions of ubuntu into CI workflow. This makes sure there is a build against Qt6. The added jobs do not make packaging and do not run tests.
P.S. if support of ubuntu 20.04 is still important and since now on ubuntu 22.04 qt 5.15 is used, it is probably worth to simplify install.sh script and build against legacy Qt 5.12, since it is still kinda supported, see #531