Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dlt files split #621

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dlt files split #621

wants to merge 2 commits into from

Conversation

vifactor
Copy link
Collaborator

@vifactor vifactor commented Feb 2, 2025

@vifactor vifactor self-assigned this Feb 2, 2025
@vifactor vifactor added this to the Release v2.28.0 milestone Feb 2, 2025
@alexmucde
Copy link
Collaborator

Interesting feature. Can you also add the begin/end Data/Time to the filename of the split files?
Would be good if we can split the file already when importing e.g. from MF4.

@vifactor
Copy link
Collaborator Author

vifactor commented Feb 8, 2025

Can you also add the begin/end Data/Time to the filename of the split files?

sure, in what format you want to have that?

Would be good if we can split the file already when importing e.g. from MF4.

I can do that in a separate PR, but I would need from you an example of MF4 file. I never use those and have no samples.

@vifactor vifactor force-pushed the dlt-files-split branch 2 times, most recently from 9896c7d to db0e345 Compare February 10, 2025 20:35
@alexmucde
Copy link
Collaborator

Can you also add the begin/end Data/Time to the filename of the split files?

sure, in what format you want to have that?

We have something like this in our logger files: 2024-10-22_22-24-47_2024-10-22_22-26-47_
It will be best to add this to the beginning of the file for better sorting.

Would be good if we can split the file already when importing e.g. from MF4.

I can do that in a separate PR, but I would need from you an example of MF4 file. I never use those and have no samples.
Bad i a cannot share our MF4 files.

@vifactor
Copy link
Collaborator Author

Bad i a cannot share our MF4 files.

I have found some random mf4 files in Internet. However, I do not understand how to process them with the commander. This line

if(opt.getLogFiles().size()<1)
prevents me from importing only mf4, a dlt file must be importer alongside:

ERROR: No DLT file used. At least one DLT file must be provided.

It also command line example given for --help option does not work: dlt-commander -c output.txt input1.mf4 input2.mf4 is not actually working, right?

@vifactor vifactor removed the WIP label Mar 1, 2025
@vifactor vifactor marked this pull request as ready for review March 1, 2025 09:55
vifactor added 2 commits March 1, 2025 21:09
#363

Improve const correctness for other getters

implement dedicated dlt exporter

Signed-off-by: Viktor Kopp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants