Persist Search History #635
Conversation
Persist the search history even across DLT Viewer restarts. Signed-off by : Pavithra Anand <[email protected]>
src/mainwindow.cpp
Outdated
| @@ -8292,6 +8305,19 @@ void MainWindow::onSearchProgressChanged(bool isInProgress) | |||
| ui->dockWidgetProject->setEnabled(!isInProgress); | |||
| } | |||
|
|
|||
| void MainWindow::loadSearchHistoryList(QStringList& searchHistory) | |||
There was a problem hiding this comment.
Could you please move this whole stuff into the corresponding widget (search form or search dialog) instead of extending main window which is already a polluted superclass antipattern?
There was a problem hiding this comment.
Ok, will move it to search dialog
Moved loadSearchHistoryList function from mainwindow to searchdialog Signed-off by : Pavithra Anand <[email protected]>
| QAction *searchHistoryActs[MaxSearchHistory]; | ||
| QStringList searchHistory; | ||
|
|
||
| QLineEdit* searchLineEdit; |
There was a problem hiding this comment.
can all this be also moved to the corresponding widget?
There was a problem hiding this comment.
Yes, sure. Will move to search form/search dialog
There was a problem hiding this comment.
I have already utilised searchHistory which is QStringList in saving and loading history functions.
In searchForm, I could see m_historyModel which is QStringListModel is defined.
So, Is it expected to proceed with searchHistory or m_historyModel?
Persist the search history even across DLT Viewer restarts.
Signed-off by : Pavithra Anand [email protected]