[2주차] 객체지향 코드 연습(baaamk) #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baaamk
requested review from
Hoya324,
KoSeonJe,
Gopistol and
TaetaetaE01
as code owners
Hoya324
reviewed
Apr 3, 2024
Accountfile/Account.java
Outdated
| return value; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Accountfile/Account.java
Outdated
| @Setter | ||
|
|
||
| public class Account { | ||
| protected String accountType; |
There was a problem hiding this comment.
accountType은 private가 아니라 protected인 이유가 있나요?
Accountfile/Account.java
Outdated
Comment on lines
19
to
45
| private boolean isActivated; | ||
| public Account() { | ||
| isActivated = true; | ||
| accountType = "N"; | ||
| } | ||
| public Account(String accountNumber, String owner, BigDecimal balance){ | ||
| this(); | ||
| this.accountNumber = accountNumber; | ||
| this.owner = owner; | ||
| this.balance = balance; | ||
| } | ||
| public String getAccountInfo(){ | ||
| return "계좌 종류:" + accountType + "\n" + | ||
| "계좌번호:" + accountNumber + "\n" + | ||
| "이름:" + owner + "\n" + | ||
| "잔액:" + balance + "\n" + | ||
| "활성화:" + isActivated; | ||
| } | ||
| public BigDecimal withdraw(BigDecimal value) { | ||
| this.balance = this.balance.subtract(value); | ||
| return value; | ||
| } | ||
|
|
||
| public BigDecimal deposit(BigDecimal value) { | ||
| this.balance = this.balance.add(value); | ||
| return value; | ||
| } |
There was a problem hiding this comment.
메서드와 메서드 사이에 개행을 추가해주시면 가독성이 더 좋은 코드가 될거 같습니다!
Bank/Bank.java
Outdated
|
|
||
| public class Bank { | ||
| protected static Scanner scanner = new Scanner(System.in); | ||
| protected static int seq = 0;//<- 추가되는 계좌 개수 |
There was a problem hiding this comment.
매직넘버에 대해 한번 알아보시고 0을 INIT_ACCOUNT_NUMBER 과 같은 변수명으로 상수 처리해주시면 더 좋은 코드가 될거 같아요!
Bank/Bank.java
Outdated
Comment on lines
24
to
39
| public void withdraw(){ | ||
| Account account = null; | ||
| System.out.println("출금계좌를 입력하세요."); | ||
|
|
||
| String accountNumber = scanner.next(); | ||
| account = findAccount(accountNumber); | ||
| if (account.getAccountType().equals("s")) { | ||
| new SavingBank().withdraw((SavingAccount) account); | ||
| } | ||
| System.out.println("출금 금액을 입력하세요"); | ||
| BigDecimal value = scanner.nextBigDecimal(); | ||
| BigDecimal result; | ||
| BigDecimal interest = interestCalculators.get(account.getAccountType()).getInterest(account.getBalance()); | ||
| result = account.withdraw(value); | ||
| System.out.println("출금액 %s원과 이자 %s원이 정상적으로 출금되었습니다."); | ||
| } |
There was a problem hiding this comment.
출금에 대한 역할에 출금계좌 입력, 출금 금액 입력, 출금 결과 반환과 같이 여러가지인 것으로 보입니다! SRP를 지키게 하려면 어떻게 해야할지 한번 고민해보시면 좋을걱 같아요!
Bank/CentralBank.java
Outdated
| private static CentralBank instance = new CentralBank(); | ||
|
|
||
| private static String BANK_NAME = "중앙은행"; | ||
| private ArrayList<Account> accountList = new ArrayList<>(); |
There was a problem hiding this comment.
일급 컬렉션에 대해 한번 알아보시면 좋아보이네요!
Bank/CentralBank.java
Outdated
|
|
||
| // accountList getter/setter <- 중앙은행 인스턴스와 계좌 접근 가능 | ||
| public ArrayList<Account> getAccountList() { | ||
| return accountList; |
There was a problem hiding this comment.
이렇게 accountList를 전달한다면 List의 수정을 막을 수 있을까요? set이 아닌, 즉 의도하지 않은 수정을 만들 수 있을 겁니다!
아래의 자료를 한번 참고해보세요!
https://blog.naver.com/seek316/223325763759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가 Q & A
🤔 잘 모르겠거나, 더 궁금한 내용이 있었나요?
너무 모르는거 투성이라,,
집중적으로 리뷰 받고싶은 것이 있나요?