Skip to content

Commit

Permalink
CSCEXAM-1404 User agreemenet promp for all roles
Browse files Browse the repository at this point in the history
  • Loading branch information
lupari committed Jan 28, 2025
1 parent 67f95cc commit cfdebeb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion app/controllers/user/UserController.java
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@ public Result getUnenrolledStudents(Long eid, String criteria) {
}

@Authenticated
@Restrict({ @Group("STUDENT") })
public Result updateUserAgreementAccepted(Http.Request request) {
Result result;
User user = DB.find(User.class)
Expand Down
3 changes: 1 addition & 2 deletions ui/src/app/session/session.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,7 @@ export class SessionService implements OnDestroy {

private processLogin$(user: User): Observable<User> {
const userAgreementConfirmation$ = (u: User): Observable<User> =>
// switchMap((u: User) => (u.isStudent && !u.userAgreementAccepted ? this.openUserAgreementModal$(u) : of(u)));
defer(() => (u.isStudent && !u.userAgreementAccepted ? this.openUserAgreementModal$(u) : of(u)));
defer(() => (!u.userAgreementAccepted ? this.openUserAgreementModal$(u) : of(u)));
return user.loginRole
? userAgreementConfirmation$(user)
: this.openRoleSelectModal$(user).pipe(switchMap((u) => userAgreementConfirmation$(u)));
Expand Down

0 comments on commit cfdebeb

Please sign in to comment.