CSCEXAM-1396 Add titles to teacher and admin tab title #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirmasaloA
commented
Jan 30, 2025
| @@ -31,6 +31,7 @@ export const APP_ROUTES: Route[] = [ | |||
| { | |||
| path: 'logout', | |||
| component: LogoutComponent, | |||
| title: () => buildTitle('i18n_logout_title'), | |||
There was a problem hiding this comment.
Tää on periaatteessa turha, koska tää sivu näkyy ruudulla noin 20 millisekuntia
VirmasaloA
commented
Jan 30, 2025
| @@ -115,7 +116,7 @@ export const APP_ROUTES: Route[] = [ | |||
| path: 'enrolments/:id', | |||
| loadComponent: () => | |||
| import('./enrolment/exams/exam-enrolments.component').then((mod) => mod.ExamEnrolmentsComponent), | |||
| title: (route) => buildTitle('i18n_enrolment_title', `#${route.params.id}`), | |||
| title: () => buildTitle('i18n_enrolment_title'), | |||
There was a problem hiding this comment.
Totesin numeroinnin ylimääräiseksi niin poistin sen kaikista kohista kokonaan
VirmasaloA
commented
Jan 30, 2025
| const extra = extraPart ? ` ${extraPart}` : ''; | ||
| return tx.get(key).pipe(map(() => `${tx.instant(key)}${extra} - EXAM`)); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Oisko tän voinu tehä niin että funktion ois hakenu app.routes filusta?
VirmasaloA
force-pushed
the
CSCEXAM-1396
branch
from
622c67b to
61fd037
Compare
lupari
approved these changes
Jan 30, 2025
|
Kielitiedostoissa oli 1. ylimääräsiä välilyöntejä 2. erikoismerkkinä merkattuja välilyöntejä. AI halus välttämättä korjaa ne ja oon sen kanssa samaa mieltä. Oon joskus korjannu niitä manuaalisesti, mut nyt ku se olli automaattista nii se oli kivan helppo suoritus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.