Default to v9 semantics in clang #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
force-pushed
the
default-to-v9
branch
from
4b0f8bd to
18e8d01
Compare
|
Depends on CTSRD-CHERI/cheribsd#2322 |
|
@jrtc27 CTSRD-CHERI/cheribsd#2322 has been merged - ok to merge this? |
|
Ci failure caused by llvm/llvm-project#126302 |
…rsing No functional change intended.
This may have been needed before ISAInfo handled custom extensions, but now we can just defer to ISAInfo. No functional change intended
The upcoming standard no longer includes cgetoffset (and cgetaddr has been removed in ISAv9). For now the assembly code still accepts cgetaddr and converts it to a move, but use an intrinsic call instead as that can be optimized to a subregister read on next use rather the requiring an explicit move.
This also handles implied features and therefore is more future-proof than a simple string comparison.
We have to use XLenVT for getting the intrinsic type otherwise we end up triggering an assertion in LegalizeDAG.
Mostly just updates the RUN line, but in some cases changes the checks for function signature. Change in preparation for the next commit. No functional change intended
No longer needed with opaque pointers.
This allows quite a lot of cleanup now that all supported implementations of CHERI-RISC-V default to ISAv9 semantics. Most importantly all the logic to handle trapping instructions can be dropped as well as the legacy support for CToPtr/CFromPtr.
This was missed in CTSRD-CHERI#708
arichardson
force-pushed
the
default-to-v9
branch
from
18e8d01 to
159332b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we would delete all this backwards compatibility code, but there
might still be implementations around that depend on the old behaviour.
Keep it until we are sure it can be deleted.
Also some minor refactoring in preparation for #756