fix middle click sending bacon to outer heaven #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes bacon handle mouse events. Downsides: - potential regression for users pasting with middle click - major regression for users selecting and copying with the mouse - not using the scroll multiplier defined OS wide Fix #298
|
Managing a menu on right click, selecting with the mouse, this looks quite feasible. But some people probably use other mouse related features, eg other menu enabled features that would be specific to their terminal application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #298
The problem of middle-click is that it's used on linux (especially linux terminals) to send as key events the content of the clipboard.
This PR "solves" the problem by making bacon manage mouse events by itself.
With this PR, bacon scrolls up and down using the mouse wheel events.
Downsides:
Given the downsides, this PR can't be merged right now.
I would need at least to manage selecting (which could be better that today's selection as it would handle the scrollbar correctly), but also replace the menu for copying that most terminals propose on right click.