Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MH3 card scripts #4754

Closed
wants to merge 208 commits into from
Closed

MH3 card scripts #4754

wants to merge 208 commits into from

Conversation

dracontes
Copy link
Contributor

@dracontes dracontes commented Feb 27, 2024

(Split from #4746 )
Tested card scripts

  • Flare of Cultivation
  • Snow-Covered Wastes
  • Ajani, Nacatl Pariah // Ajani, Nacatl Avenger: I'll freely admit: the sequential ImmediateTrig on the second loyalty ability aren't in any way elegant but these were the only thing I could think of to satisfy both the "When you do [create a token this way]" and the "if you control a red permanent other than Ajani, Nacatl Avenger" conditions. Probably not the smartest thing to draw attention to the former as an intermediate step. I'm all ears for better options.

@dracontes dracontes mentioned this pull request Feb 27, 2024
@paulsnoops
Copy link
Contributor

@dracontes I invited you to be a contributor so you can claim the cards you're working on in the projects

@dracontes
Copy link
Contributor Author

@dracontes I invited you to be a contributor so you can claim the cards you're working on in the projects

Much obliged for the invitation :) Claiming done.

@dracontes dracontes marked this pull request as ready for review February 28, 2024 20:49
SVar:TrigToken:DB$ Token | TokenAmount$ 1 | TokenScript$ w_2_1_cat_warrior | TokenOwner$ You
T:Mode$ ChangesZoneAll | TriggerZones$ Battlefield | ValidCards$ Cat.Other+YouCtrl | Origin$ Battlefield | Destination$ Graveyard | Execute$ TrigExile | OptionalDecider$ You | TriggerDescription$ Whenever one or more other Cats you control die, you may exile NICKNAME, then return him to the battlefield transformed under his owner's control.
SVar:TrigExile:DB$ ChangeZone | Origin$ Battlefield | Destination$ Exile | RememberChanged$ True | SubAbility$ DBReturn
SVar:DBReturn:DB$ ChangeZone | Defined$ Remembered | Origin$ Exile | Destination$ Battlefield | Transformed$ True | ForgetOtherRemembered$ True | SubAbility$ DBCleanup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you're using ForgetOtherRemembered the Cleanup does become redundant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed ForgetOtherRemembered then as it ostensibly reads as less widely applicable. The card script works fine at least.

A:AB$ PutCounterAll | Cost$ AddCounter<2/LOYALTY> | ValidCards$ Cat.YouCtrl | CounterType$ P1P1 | CounterNum$ 1 | Planeswalker$ True | SpellDescription$ Put a +1/+1 counter on each Cat you control.
A:AB$ Token | Cost$ AddCounter<0/LOYALTY> | TokenAmount$ 1 | TokenScript$ w_2_1_cat_warrior | TokenOwner$ You | RememberTokens$ True | SubAbility$ DBImmediateTrig1 | Planeswalker$ True | SpellDescription$ Create a 2/1 white Cat Warrior creature token. When you do, if you control a red permanent other than CARDNAME, he deals damage equal to the number of creatures you control to any target.
SVar:DBImmediateTrig1:DB$ ImmediateTrigger | ConditionDefined$ Remembered | ConditionPresent$ Card | Execute$ ImmediateTrig2 | SubAbility$ DBCleanup | TriggerDescription$ When you do,...
SVar:ImmediateTrig2:DB$ ImmediateTrigger | ConditionPresent$ Permanent.Red+YouCtrl+Other | Execute$ TrigDamage | TriggerDescription$ When you do, if you control a red permanent other than CARDNAME, he deals damage equal to the number of creatures you control to any target.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would give you two reflexive triggers
you should only use one, ConditionPresent2$ exists so you can have both
and the DealDamage needs to check for it too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much obliged for the pointer :) Done and tested. Unfortunately this pull request even split is one big mess so I'll be starting this one over on a fresh branch. My apologies for that.

@dracontes dracontes mentioned this pull request Mar 1, 2024
@dracontes
Copy link
Contributor Author

Turns out to be too much of a mess for me to fix so closing it and starting over.

@dracontes dracontes closed this Mar 1, 2024
@dracontes dracontes deleted the dracontes-mh3 branch October 13, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants