Future proofing mana base for 4 color generated decks #6730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating 4 color decks, the code did not generate any dual lands for the color combo of index 2 and 3 in the colors array. While there are currently no enemies that generate 4 color decks, this change would future proof such decks, in case any 4 color deck templates are added.
|
Error: COMPILATION ERROR : |
tehdiplomat
reviewed
Jan 4, 2025
|
|
||
| base.subTypes = new String[]{landName.get(0),landName.get(1)}; | ||
| sub1.subTypes = new String[]{landName.get(0),landName.get(2)}; | ||
| sub2.subTypes = new String[]{landName.get(0),landName.get(3)}; | ||
| sub3.subTypes = new String[]{landName.get(1),landName.get(2)}; | ||
| sub4.subTypes = new String[]{landName.get(1),landName.get(3)}; | ||
| rewards.addAll(Arrays.asList(sub1,sub2,sub3,sub4)); | ||
| sub5.subtypes = new String[]{landName.get(2),landName.get(3)}; |
There was a problem hiding this comment.
Did you test this? The tests fail, and there's a typo here (the t in subtypes isn't capitalized)
|
This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating 4 color decks, the code did not generate any dual lands for the color combo of index 2 and 3 in the colors array. While there are currently no enemies that generate 4 color decks, this change would future proof such decks, in case any 4 color deck templates are added.