AmassEffect: use Effect in Command Zone for Type Change

[Hanmac]

Part of #5642 to reduce the amount of addChangedCardTypes

[tool4ever]

I'm not sure there exists a dependency where not applying this one first (or rather always like before) would be required.
So for a short while until we support them this might behave a bit worse?
I guess ideally it would just call AnimateEffectBase.doAnimate but that's a pretty big refactor 😅

[Hanmac]

@tool4ever effects that removes all creature types except chosen ones for example should apply first, and then the add Creature Type after

I might look into it refactoring AnimateBase later

But first I want to remove the use of addChangedCardTypes

[tool4ever]

If you cast something like Mercurial Transformation after Amass it should just be applied by timestamp order and overwrite everything.

[Hanmac]

If you cast something like Mercurial Transformation after Amass it should just be applied by timestamp order and overwrite everything.

No, i mean using Conspiracy to transform some non Army into an Army. And then use the Amass Effect to turn it onto a Zombie/Orc/Sliver.

That's why this doesn't work:

I'm not sure there exists a dependency where not applying this one first (or rather always like before) would be required.

[tool4ever]

But that works already, this doesn't lead to a dependency by itself and you will have an Army Zombie

[Hanmac]

But that works already, this doesn't lead to a dependency by itself and you will have an Army Zombie

Yes, but i don't want it to be broken later by applying this one first

[Hanmac]

@tool4ever should we apply #6792 first, so I can hide the Amass Effect?