Bestow as Static Effect

[Hanmac]

Closes #6811

currently it causes flickering

And sometimes, the Bestow Effect isn't removed as it should, but I can't find the remaining one.
That causes the Creature Spell still be cast as Aura even if it shouldn't.

And sometimes, the effect might be removed, but the static effect of the effect isn't cleared

[tool4ever]

else is wrong
just move it into the block above

[Hanmac]

in theory undoAlternateHost could handle reverting castFaceDown too

[tool4ever]

need to find a way to also cleanup when it leaves stack without resolving

[Hanmac]

Leaving the stack without resolving should already call unanimateBestow directly

[tool4ever]

it seems CounterEffect would call it
but ChangeZoneEffect not currently

[Hanmac]

@tool4ever i couldn't pinpoint the cause of the issues yet (both visual and functional)

but my gut is telling me that the Remembered List of the LKI could be a cause.
Right now when the Effect are copied, the remembered still uses the original objects?

forge/forge-game/src/main/java/forge/game/card/CardCopyService.java

Lines 342 to 344 in a4b2732

	newCopy.addRemembered(copyFrom.getRemembered());
	newCopy.addImprintedCards(copyFrom.getImprintedCards());
	newCopy.setChosenCards(copyFrom.getChosenCards());

[tool4ever]

Probably need to manually add the effect to Command instead so you have greater control over when statics are applied 🤔

[Hanmac]

Probably need to manually add the effect to Command instead so you have greater control over when statics are applied 🤔

I think the main problem are that Bestow uses LKI -> StaticEffect to check.

And then the LKI object isn't used anymore, but the StaticEffect might still linger ...
I tried debugging it, but i haven't found all cases where the BestowEffect should be removed again after checks.

Especially the ones where you Cancel the Spell cast