Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-775 Make the saving after tool change consistent for all tools #1345

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

khalid-nasralla
Copy link
Contributor

@khalid-nasralla khalid-nasralla commented Feb 18, 2025

PAINTROID-775

Behavior before:
When using Text-, Clipboard-, Image-, Shapes-Tools and not confirming/clicking on the checkmark to actually apply the Tool onto the canvas And then switching to another Tool, would still use the Tool regardless.

Behavior now:
When using Text-, Clipboard-, Image-, Shapes-Tools the user needs to confirm with the checkmark to apply it and it won't get applied automatically anymore when switching to another Tool.

I also changed the Clipboard behavior to function that way like the other tools hate have a checkmark for confirmation, because it wouldn't by default since it doesn't use a checkmark.

Added an Auto-Save functionality to the Advanced Settings of the Top-bar menu:
image

Disabled: Using one of the named Tools and switching to another Tool without confirming doesn't apply it.
Enabled: Using one of the named Tools and switching to another Tool without confirming still applies the Tool regardless and automatically saves it to the Canvas.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant