Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding playbook for ODCS deployment #10

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Conversation

mohanboddu
Copy link
Contributor

This is a WIP, please hold on merging until CentOS/ansible-role-odcs-backend#1 and CentOS/ansible-role-odcs-frontend#1 are merged.

Signed-off-by: Mohan Boddu [email protected]

@arrfab
Copy link
Member

arrfab commented Nov 18, 2020

LGTM so we can already merge this, as it's independent from the work being done on these two roles, in their own git repositories.
So holding for now but imho this could be merged already :)

role-odcs.yml Outdated
@@ -0,0 +1,49 @@
---
- name: Setup ODCS frontend
Copy link
Member

@arrfab arrfab Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have role-odcs-frontend.yml and role-odcs-backend.yml, themselves calling corresponding role ? Just to keep the logic we use so far, as automated ansible deploy will try to ensure each git repo/role is up2date before kicking ansible-playbook for the role

And BTW, that's how it's declared in role-all.yml : two different playbooks, so they should exist and the role-odcs.yml deleted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arrfab, I fixed it

@arrfab
Copy link
Member

arrfab commented Nov 19, 2020

@mohanboddu : thanks a lot for the change. Happy to merge it if that also works for you (as we don't need fully tested role for this PR)

Copy link
Contributor Author

@mohanboddu mohanboddu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohanboddu : thanks a lot for the change. Happy to merge it if that also works for you (as we don't need fully tested role for this PR)

Sure, go ahead

role-odcs.yml Outdated
@@ -0,0 +1,49 @@
---
- name: Setup ODCS frontend
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arrfab, I fixed it

@arrfab arrfab merged commit 65d2fbc into CentOS:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants