Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Adding 'centos-quarkus.io-jdk8' stack to container-index #395

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

ibuziuk
Copy link
Contributor

@ibuziuk ibuziuk commented Apr 17, 2019

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@ibuziuk
Copy link
Contributor Author

ibuziuk commented Apr 17, 2019

cc: @vorburger

@ibuziuk
Copy link
Contributor Author

ibuziuk commented Apr 17, 2019

@bamachrn @dharmit could you please merge?

@dharmit
Copy link
Collaborator

dharmit commented Apr 17, 2019

ok to test

@ibuziuk
Copy link
Contributor Author

ibuziuk commented Apr 17, 2019

@dharmit build looks broken for a while - https://ci.centos.org/job/centos-container-index-ci/
is it a blocker for merging?

@dharmit
Copy link
Collaborator

dharmit commented Apr 17, 2019

@dharmit build looks broken for a while - https://ci.centos.org/job/centos-container-index-ci/
is it a blocker for merging?

@ibuziuk Yes, you are right. I took a look to see if something related to quarkus was off but it doesn't look that way. I'm inclined to merge this but am a bit hesitant to do it immediately due to a . in the name. I'm giving this a spin in my environment to be sure.

If all goes well, I'll merge it in the morning. It's nearly midnight here. 😉

@ibuziuk
Copy link
Contributor Author

ibuziuk commented Apr 17, 2019

@dharmit FYI having a dot is correct in quay repos [1]
https://gitlab.cee.redhat.com/service/app-interface/merge_requests/397/diffs

@dharmit
Copy link
Collaborator

dharmit commented Apr 17, 2019

LGTM. Merging since the CI errors don't seem to be related to the PR in question.

@dharmit dharmit merged commit f8d9593 into CentOS:master Apr 17, 2019
@ibuziuk
Copy link
Contributor Author

ibuziuk commented Apr 23, 2019

@dharmit looks like there still

Trying to pull repository registry.centos.org/che-stacks/centos-quarkus.io-jdk8 ... 
Pulling repository registry.centos.org/che-stacks/centos-quarkus.io-jdk8
Error: image che-stacks/centos-quarkus.io-jdk8:latest not found

how should the initial image registry.centos.org/che-stacks/centos-quarkus.io-jdk8 happen with the current flow?

@bamachrn
Copy link
Collaborator

@dharmit @ibuziuk image is pushed as registry.centos.org/che-stacks/centos-quarkus-io-jdk8:latest we are looking for quarkus.io?

@vorburger
Copy link
Contributor

So docker pull registry.centos.org/che-stacks/centos-quarkus-io-jdk8:latest seems to work now (as in it pulls, haven't actually tested the image, yet). I can't find it on the UI though, and have opened CentOS/container-pipeline-service#689 about that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants