Adding more tests for the index CI #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #583 |
mohammedzee1000
force-pushed
the
index_ci_refac_5
branch
from
5cd5b21 to
28365c4
Compare
Git path can start with "/" which is problem for os.path.join
The engine can now be given a state object to use. This enables user to create the state object outside, initialize extra stuff, and then pass it to the engine to use. Also adding functional tests.
mohammedzee1000
force-pushed
the
index_ci_refac_5
branch
from
fdfe660 to
6955d06
Compare
Signed-off-by: Mohammed Zeeshan Ahmed <[email protected]>
mohammedzee1000
changed the title
navidshaikh
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part 2 of adding tests for index CI. As the number of tests increase, they have been broken down.
Merge after : #587