feat: Add parallelism support for sqlness #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 6 out of 10 changed files in this pull request and generated 2 comments.
Files not reviewed (4)
- sqlness/src/interceptor.rs: Evaluated as low risk
- sqlness/examples/basic.rs: Evaluated as low risk
- sqlness/Cargo.toml: Evaluated as low risk
- sqlness/src/environment.rs: Evaluated as low risk
Comments suppressed due to low confidence (2)
sqlness/src/runner.rs:170
- Ensure that the new parallelism feature is explicitly tested to verify its behavior.
futures::future::join_all(futures).await;
sqlness/examples/bad.rs:19
- The removal of the return statement may affect the intended behavior. Consider adding the return statement back.
Box::new("Unexpected")
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
waynexia
changed the title
jiacai2050
approved these changes
Feb 13, 2025
| /// The id is used to distinguish different database instances in the same environment. | ||
| /// For example, you may want to run the sqlness test in parallel against different instances | ||
| /// of the same environment to accelerate the test. | ||
| async fn start(&self, env: &str, id: usize, config: Option<&Path>) -> Self::DB; |
There was a problem hiding this comment.
Strings can be used for identifiers (id) because they offer flexibility and can accommodate any character-based data, making them suitable for dynamic or user-generated IDs that might include numbers, letters, or special characters.
| let db = self.env_controller.start(&env, config_path).await; | ||
| let run_result = self.run_env(&env, &db).await; | ||
| self.env_controller.stop(&env, db).await; | ||
| let parallelism = self.config.parallelism.max(1); |
There was a problem hiding this comment.
min will become either 0 or 1. This is "take the min/max among two" (really misleading, I've fallen into this many times...)
| @@ -112,6 +112,7 @@ fn main() { | |||
|
|
|||
| let config = ConfigBuilder::default() | |||
| .case_dir(args.case_dir) | |||
| .parallelism(1) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The test time can be very long with increasing test cases. Supporting run them in parallel is a way to relieve this.
Detailed Changes
Support to build multiple environments, and schedule test cases to those env on file level
Test Plan
This change itself is relatively simple, and a major part is for lifetime