-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for iTwin Geospatial Features API #12449
base: main
Are you sure you want to change the base?
Conversation
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jjspace! Code looks good to me!
It looks like CI is failing, could you please double check that?
@ggetz fixed, should be good now, silly little issue with too many |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jjspace! Code all looks good. I'll merge once we have confirmation about the dataset.
@jjspace In the Sandcastle example, could you please update the points id to use |
@ggetz done, looks good |
Description
ITwinData.loadGeospatialFeatures
Issue number and link
No issue, follow up for #12344
Testing plan
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change