fix(sync/paseo): Ignoring config value for min peer #4289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimjbrettj
added
T-bug
jimjbrettj
requested review from
EclesioMeloJunior,
timwu20 and
kishansagathiya
as code owners
EclesioMeloJunior
approved these changes
Oct 29, 2024
haikoschol
approved these changes
Oct 30, 2024
jimjbrettj
force-pushed
the
jimmy/fixPaseoSync
branch
from
c4514eb
to
1ddcb90
Compare
|
superseded by #4291 |
auto-merge was automatically disabled
October 30, 2024 14:44
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In the sync code, we do not send handshake messages until we have available workers that is >= minPeers. If we do not send handshakes we do not receive announces. When starting up syncing, we send a dummy handshake message so that we receive a block announce which we then use to set the target block.
This is okay, except that the config value for minPeers overrides the sync packages default and sets it to 0, and thus we get stuck waiting for block announces and syncing stalls because a target is never set.
Ideally, this is solved with something like #4257. However, given that #4257 introduced a regression and this is a very urgent issue, I have come up with a workaround to ignore the config value here and use the default sync package value.
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
#4288