Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds WEST BENGAL and its all districts to village_boundaries #54

Closed
wants to merge 11 commits into from
Closed

Adds WEST BENGAL and its all districts to village_boundaries #54

wants to merge 11 commits into from

Conversation

kumarguddu609
Copy link
Contributor

@kumarguddu609 kumarguddu609 commented Feb 1, 2024 •
edited
Loading

What does this PR do?

This PR adds WEST BENGAL state and its DISTRICTS to village boundary database.
There are 23 districts in WEST BENGAL as of now, but the data is of only 20 districts are available. The 3 new formed districts data is not available right now.

fixes #45

@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 Please do checks.

@dhruv-1001
Copy link
Collaborator

Hey @kumarguddu609, let's follow what i've instructed in this PR. And do that for all your PRs.

@kumarguddu609
Copy link
Contributor Author

kumarguddu609 commented Feb 3, 2024 •
edited
Loading

Hey @dhruv-1001 I have made the changes already and tracks gitLFS /geojson-data/indian_village_boundaries.zip/west_bengal only as instructed in the PR
Please do let me know if other changes is required

@dhruv-1001
Copy link
Collaborator

Can you push the changes? I'll let you know if there are any changes required.

@kumarguddu609
Copy link
Contributor Author

kumarguddu609 commented Feb 3, 2024 •
edited
Loading

Can you push the changes? I'll let you know if there are any changes required.

I Have already pushed the changes the same day as you instructed. This is the new PR that I have opened making that changes.
The old PR is closed by me where i have trakced /geojson-data/ the entire folder

@dhruv-1001
Copy link
Collaborator

We want .gitattributes to be in root of this project.
First, add the zip files to <root>/server/geojson-data/indian_village_boundaries.zip/west_bengal/
Then track using (while being in the root of project) git lfs track server/geojson-data/indian_village_boundaries.zip/west_bengal/**
This would add all the files to .gitattributes as such

server/geojson-data/indian_village_boundaries.zip/west_bengal/district_one.zip filter=lfs diff=lfs merge=lfs -text
server/geojson-data/indian_village_boundaries.zip/west_bengal/district_two.zip filter=lfs diff=lfs merge=lfs -text
and so on ..

Commit and then push the changes.

@kumarguddu609
Copy link
Contributor Author

We want .gitattributes to be in root of this project. First, add the zip files to <root>/server/geojson-data/indian_village_boundaries.zip/west_bengal/ Then track using (while being in the root of project) git lfs track server/geojson-data/indian_village_boundaries.zip/west_bengal/** This would add all the files to .gitattributes as such

server/geojson-data/indian_village_boundaries.zip/west_bengal/district_one.zip filter=lfs diff=lfs merge=lfs -text
server/geojson-data/indian_village_boundaries.zip/west_bengal/district_two.zip filter=lfs diff=lfs merge=lfs -text
and so on ..

Commit and then push the changes.

Okay

@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 I have made and changes as instructed and pushed the changes. Let me know if any changes required.

@kumarguddu609 kumarguddu609 mentioned this pull request Feb 3, 2024
Merged
@dhruv-1001
Copy link
Collaborator

Let's do the same thing here as well, the one gave instructions about on PUDUCHERRY PR.

@kumarguddu609
Copy link
Contributor Author

Let's do the same thing here as well, the one gave instructions about on PUDUCHERRY PR.

I have changed on the both PRs also removes the Fixes #28 from both PRs

@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 can you do the merge if no further changes is required?

@dhruv-1001
Copy link
Collaborator

dhruv-1001 commented Feb 5, 2024 •
edited
Loading

LGTM. Just squash your commits to one. Also, rebase.

@kumarguddu609 kumarguddu609 force-pushed the add/village_boundaries branch from 95e9c2d to c17dc0f Compare February 6, 2024 09:13
@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 I have rebased and squashed the commit to one. Do check and let me know if changes required. if it looks good kindly do merge.

@kumarguddu609 kumarguddu609 force-pushed the add/village_boundaries branch from 6ba70bf to 9997521 Compare February 6, 2024 17:18
@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 Can you do checks.

@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 I have resolved merge conflits here. So merge it and close the issue.
Thanks

@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 can you assign me this issue and then merge it.

@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 Can you assign and merge this PR.

@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 I have again resolves the merge conflict. It LGTM, can you merge it.

@dhruv-1001
Copy link
Collaborator

Hey, @kumarguddu609. Dir name should be indian_villages_boundaries.zip, and not indian_village_boundaries.zip. Can you move files there, i'll merge this once you are done.

@kumarguddu609
Copy link
Contributor Author

indian_villages_boundaries

I will move files there and let you know

@kumarguddu609
Delete server/geojson-data/indian_villages_boundaries.zip directory
e72e5bc
@kumarguddu609
done
87302f6 
Update update-mmdb.yaml

Added workflow to build image. (ChakshuGautam#42)

tracks and adds west bengal

feat: modify script to download available village boundary data

feat: update Dockerfile to fix deployment (ChakshuGautam#55)
@kumarguddu609
done
0157f76 
Update update-mmdb.yaml

Added workflow to build image. (ChakshuGautam#42)

tracks and adds west bengal

feat: modify script to download available village boundary data

feat: update Dockerfile to fix deployment (ChakshuGautam#55)

Uploaded files to git lfs

Added all files and .gitignore file

Added all files for lakshwadeep

added all 75 files for up

tracks git LFS of puducherry

tracks /geojson-data/indian_village_boundaries.zip/puducherry

feat: implement fuzzy search API
@kumarguddu609
done
cd4f09f 
Update update-mmdb.yaml

Added workflow to build image. (ChakshuGautam#42)

tracks and adds west bengal

feat: modify script to download available village boundary data

feat: update Dockerfile to fix deployment (ChakshuGautam#55)

Uploaded files to git lfs

Added all files and .gitignore file

Added all files for lakshwadeep

added all 75 files for up

tracks git LFS of puducherry

tracks /geojson-data/indian_village_boundaries.zip/puducherry

feat: implement fuzzy search API

Added Delhi data (ChakshuGautam#64)

* chore: add data for delhi

---------

Co-authored-by: Dhruv Baliyan <[email protected]>

Delete server/geojson-data/indian_village_boundaries.zip directory

Delete server/geojson-data/indian_villages_boundaries.zip directory

Update .gitignore

add west_bengal
@kumarguddu609
Merge branch 'add/village_boundaries' of https://github.com/kumargudd…
906348d 
…u609/geoip into add/village_boundaries
@kumarguddu609 kumarguddu609 mentioned this pull request Feb 12, 2024
Closed
@kumarguddu609 kumarguddu609 reopened this Feb 13, 2024
@kumarguddu609 kumarguddu609 deleted the add/village_boundaries branch February 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Village Data Collection - WEST BENGAL
2 participants
@kumarguddu609 @dhruv-1001