Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added files for Himachal Pradesh #79

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

MayaSatishRao
Copy link
Contributor

@MayaSatishRao MayaSatishRao commented Feb 4, 2024

Closes: #77
Added gdb folders of all villages of Himachal Pradesh

@dhruv-1001
Copy link
Collaborator

Once you run git lfs track /server/geojson-data/indian_villages_boundaries.zip/himachal_pradesh/** this would all the files to the .gitattribute file.
Right now, these files are not uploaded to git lfs

@MayaSatishRao
Copy link
Contributor Author

MayaSatishRao commented Feb 5, 2024

@dhruv-1001 after running the command git lfs track /server/geojson-data/indian_villages_boundaries.zip/himachal_pradesh/** Should the tracking be done using git lfs track /server/geojson-data/indian_villages_boundaries.zip/himachal_pradesh instead? what should have I done?

@dhruv-1001
Copy link
Collaborator

Running git lfs track /server/geojson-data/indian_villages_boundaries.zip/himachal_pradesh/** would have added all .zip files in .gitattributes. We need to do that.

@MayaSatishRao
Copy link
Contributor Author

@dhruv-1001 I did run the same command.

@dhruv-1001
Copy link
Collaborator

Please push the changes.

@MayaSatishRao
Copy link
Contributor Author

Please push the changes.

I have made the PR

@dhruv-1001
Copy link
Collaborator

I don't see files being added to .gitattribute. We need something like this - https://github.com/ChakshuGautam/geoip/pull/35/files

@MayaSatishRao
Copy link
Contributor Author

I ran the following commands:

  1. git lfs track /server/geojson-data/indian_villages_boundaries.zip/himachal_pradesh/**
  2. git add .
  3. git commit -m "..."
  4. git push
    There are changes in the .gitattributes file. Do I need to change something in .gitignore file so that files are added? Because some changes to .gitignore file are there in https://github.com/ChakshuGautam/geoip/pull/35/files ?

@dhruv-1001
Copy link
Collaborator

dhruv-1001 commented Feb 5, 2024

Files tracked by git LFS can be seen as the ones Git LFS file not shown
While the ones uploaded directly to repo are shown as such Binary file not shown.

Example SS (from one of my private repo). We need add all files inside of .gitattributes so that they are not uploaded to the repo, but to Git LFS instead.
Screenshot 2024-02-05 at 1 55 52 PM

I hope this clear things up.

@MayaSatishRao
Copy link
Contributor Author

@dhruv-1001 Should have I run git lfs push command to upload the files?

@dhruv-1001
Copy link
Collaborator

yes, you need to push the changes to upload these files to git LFS.

@MayaSatishRao
Copy link
Contributor Author

@dhruv-1001 I have made the changes. The error was I uploaded the files in indian_village_boundaries.zip but it should have been indian_villages_boundaries.zip. So tracking was not happening.

@dhruv-1001
Copy link
Collaborator

LGTM. Please squash your commits to one. Then i'll merge.

@MayaSatishRao
Copy link
Contributor Author

@dhruv-1001 done!!

@dhruv-1001
Copy link
Collaborator

Hey, did you remove the .gitattribute file?
I can't see it in files

Added all files and .gitignore file
@MayaSatishRao
Copy link
Contributor Author

@dhruv-1001 I have added .gitignore file

@dhruv-1001 dhruv-1001 merged commit 08af9f4 into ChakshuGautam:master Feb 5, 2024
2 checks passed
@sagarkori143
Copy link
Contributor

Hey @MayaSatishRao ! Can you please mention all the commands in sequence for the entire process.

@MayaSatishRao
Copy link
Contributor Author

Sure!! @sagarkori143

  1. git lfs track /server/geojson-data/indian_villages_boundaries.zip/himachal_pradesh/**
  2. git add .
  3. git commit -m "..."
  4. git push -u origin branchName
    Make sure that the folder name is indian_villages_boundaries.zip

@sagarkori143
Copy link
Contributor

Thanks man!
And @MayaSatishRao Could you please review my changes also : In this PR

@MayaSatishRao
Copy link
Contributor Author

Everything looks fine now. Please ask @dhruv-1001 to review it as I am not authorized.

@jainvedant392
Copy link
Contributor

Hey @MayaSatishRao, could you please list the commands which you ran while you were squashing the commits?
I have explored on my side, but having some minor confusions. Thank you.

35C4n0r pushed a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Village Data Collection - HIMACHAL PRADESH
4 participants