Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add score column by calculating freq*length. #40

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

xslendix
Copy link
Contributor

Closes #36.

Copy link
Member

@Raymo111 Raymo111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's implement score into the CLI words command and csv export as well.

Notes for this:

  • Sort by score by default in all cases where that makes sense (i.e. basically what was frequency before, but double check).
  • Consider updating the word structure in Definitions.py to include a score attr, if it makes sense to, to avoid repetition of code
  • Extract the score calculation into a separate function for decoupling/future maintainability

src/nexus/GUI.py Outdated Show resolved Hide resolved
@xslendix xslendix force-pushed the new_score_column branch 4 times, most recently from 373c93c to cf35859 Compare August 21, 2023 21:26
src/nexus/Freqlog/Definitions.py Show resolved Hide resolved
src/nexus/Freqlog/Freqlog.py Outdated Show resolved Hide resolved
Copy link
Member

@Raymo111 Raymo111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, GUI needs to sort by score desc and not word desc, that's the last issue

@Raymo111 Raymo111 merged commit 0a02258 into CharaChorder:master Aug 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new score column for sorting
2 participants