-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add score column by calculating freq*length. #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's implement score into the CLI words
command and csv export as well.
Notes for this:
- Sort by score by default in all cases where that makes sense (i.e. basically what was frequency before, but double check).
- Consider updating the word structure in
Definitions.py
to include ascore
attr, if it makes sense to, to avoid repetition of code - Extract the score calculation into a separate function for decoupling/future maintainability
373c93c
to
cf35859
Compare
0367fa1
to
a8194de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, GUI needs to sort by score desc and not word desc, that's the last issue
Signed-off-by: Slendi <[email protected]>
Signed-off-by: Slendi <[email protected]>
Signed-off-by: Slendi <[email protected]>
832389d
to
f0a6314
Compare
Closes #36.