chore: add telemetry for piece indexer #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2025 12:09
NikolasHaimerl
requested review from
juliangruber,
pyropy and
bajtos
and removed request for
bajtos
juliangruber
requested changes
Feb 5, 2025
|
@NikolasHaimerl can you please resolve merge conflicts and take a stab at unifying naming? |
added 2 commits
February 5, 2025 20:15
…/github.com/filecoin-station/deal-observer into nhaimerl-add-telemetry-for-missing-payloads
juliangruber
requested changes
Feb 6, 2025
…/github.com/filecoin-station/deal-observer into nhaimerl-add-telemetry-for-missing-payloads
pyropy
requested changes
Feb 6, 2025
backend/bin/deal-observer-backend.js
Outdated
Comment on lines
130
to
133
| recordTelemetry('look_up_payload_cids_stats', point => { | ||
| point.intField('total_unresolved_payload_cids', numOfUnresolvedPayloadsCids) | ||
| point.intField('payload_cids_resolved', numOfPayloadsCidsResolved) | ||
| }) |
There was a problem hiding this comment.
Maybe we could simplify all names, include the metric names, WDYT?
Suggested change
| recordTelemetry('look_up_payload_cids_stats', point => { | |
| point.intField('total_unresolved_payload_cids', numOfUnresolvedPayloadsCids) | |
| point.intField('payload_cids_resolved', numOfPayloadsCidsResolved) | |
| }) | |
| recordTelemetry('look_up_payload_cids_stats', point => { | |
| point.intField('unresolved_payload_cids', numOfUnresolvedPayloadsCids) | |
| point.intField('resolved_payload_cids, numOfPayloadsCidsResolved) | |
| }) |
There was a problem hiding this comment.
total_unresolved_payload_cids refers to the total number all of unresolved payload cids, while resolved_payload_cids only refers to those resolved in a single round. Putting the unresolved/resolved at the beginning of the variable name does make sense though.
juliangruber
requested changes
Feb 7, 2025
Co-authored-by: Julian Gruber <[email protected]>
Co-authored-by: Julian Gruber <[email protected]>
NikolasHaimerl
deleted the
nhaimerl-add-telemetry-for-missing-payloads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The piece CID indexer fetches the payload CIDs and if it can successfully retrieve a payload CID for a given
(miner_id, piece_cid)combination it will then store it in the database.To observe the piece CID indexer two metrics are highly relevant to keep track of.