Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add http rsr #285

Merged
merged 15 commits into from
Jan 10, 2025
Merged

feat: add http rsr #285

merged 15 commits into from
Jan 10, 2025

Conversation

NikolasHaimerl
Copy link
Contributor

This MR proposes the following changes:

  1. Add http rsr metric
  2. Change the spark-evalute dependency hash to account for the recent changes made to the spar-evalute db

Related to Issue #192

@NikolasHaimerl NikolasHaimerl marked this pull request as ready for review January 9, 2025 09:50
@juliangruber
Copy link
Member

This MR proposes the following changes:

@NikolasHaimerl what does MR stand for?

juliangruber
juliangruber requested changes Jan 9, 2025
View reviewed changes
stats/lib/stats-fetchers.js Outdated Show resolved Hide resolved
stats/lib/stats-fetchers.js Outdated Show resolved Hide resolved
stats/lib/stats-fetchers.js Outdated Show resolved Hide resolved
@NikolasHaimerl
Copy link
Contributor Author

This MR proposes the following changes:

@NikolasHaimerl what does MR stand for?

Just a habit from from working with Gitlab: MR= Merge Request, PR = Pull request. Means the same thing

juliangruber
juliangruber requested changes Jan 9, 2025
View reviewed changes
stats/lib/stats-fetchers.js Outdated Show resolved Hide resolved
bajtos
bajtos requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great at the high level, let's improve the details now 👍🏻

stats/lib/stats-fetchers.js Outdated Show resolved Hide resolved
stats/lib/stats-fetchers.js Outdated Show resolved Hide resolved
stats/lib/stats-fetchers.js Outdated Show resolved Hide resolved
stats/test/handler.test.js Show resolved Hide resolved
stats/test/handler.test.js Outdated Show resolved Hide resolved
@juliangruber juliangruber mentioned this pull request Jan 9, 2025
Open
bajtos
bajtos reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised we are missing one test (see my comment below). The rest LGTM.

stats/test/handler.test.js Show resolved Hide resolved
bajtos
bajtos requested changes Jan 10, 2025
View reviewed changes
stats/test/handler.test.js Outdated Show resolved Hide resolved
@NikolasHaimerl NikolasHaimerl requested a review from bajtos January 10, 2025 10:36
bajtos
bajtos approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🏻

Since @juliangruber requested some changes in the past, please give him ~24 hours to review the final version before you proceed to land this pull request.

@NikolasHaimerl
Copy link
Contributor Author

LGTM 👏🏻

Since @juliangruber requested some changes in the past, please give him ~24 hours to review the final version before you proceed to land this pull request.

Thanks, will do :)

juliangruber
juliangruber approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@NikolasHaimerl NikolasHaimerl enabled auto-merge (squash) January 10, 2025 14:16
@NikolasHaimerl NikolasHaimerl merged commit 611c616 into main Jan 10, 2025
10 checks passed
@NikolasHaimerl NikolasHaimerl deleted the nhaimerl-add-http-rsr branch January 10, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliangruber juliangruber juliangruber approved these changes

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikolasHaimerl @juliangruber @bajtos