Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lookup plugins for rule/rules/ruleset/rulesets #476

Merged
merged 59 commits into from
Dec 20, 2023
Merged

Lookup plugins for rule/rules/ruleset/rulesets #476

merged 59 commits into from
Dec 20, 2023

Conversation

lgetwan
Copy link
Contributor

@lgetwan lgetwan commented Nov 20, 2023 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There's no lookup plugin for rules and rulesets

What is the new behavior?

Provide lookup plugins for

  • searching all rulesets,
  • showing a single ruleset,
  • listing all rules of one ruleset,
  • showing a particular rule.

Other information

This PR should be merged after Max' PR #475

@lgetwan lgetwan self-assigned this Nov 20, 2023
@lgetwan lgetwan marked this pull request as draft November 20, 2023 15:53
@lgetwan lgetwan marked this pull request as draft November 20, 2023 15:53
@robin-checkmk robin-checkmk added enhancement New feature or request lookup:rule This affects the lookup module 'rule'. lookup:rules This affects the lookup module 'rules'. lookup:ruleset This affects the lookup module 'ruleset'. lookup:rulesets This affects the lookup module 'rulesets'. labels Nov 20, 2023
@lgetwan lgetwan mentioned this pull request Nov 21, 2023
Closed
@robin-checkmk robin-checkmk mentioned this pull request Nov 22, 2023
Merged
7 tasks
@lgetwan lgetwan requested a review from Max-checkmk November 22, 2023 14:11
lgetwan and others added 18 commits December 5, 2023 15:14
@lgetwan lgetwan requested a review from godspeed-you as a code owner December 7, 2023 10:40
@lgetwan
Copy link
Contributor Author

lgetwan commented Dec 19, 2023

I will implement a "search" parameter for the rules lookup module.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 20, 2023
@robin-checkmk robin-checkmk mentioned this pull request Dec 20, 2023
Merged
7 tasks
@robin-checkmk robin-checkmk merged commit 088f0a6 into devel Dec 20, 2023
44 checks passed
@robin-checkmk robin-checkmk deleted the feature/lookup-rules branch December 20, 2023 17:08
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robin-checkmk robin-checkmk robin-checkmk approved these changes

@Max-checkmk Max-checkmk Awaiting requested review from Max-checkmk

@godspeed-you godspeed-you Awaiting requested review from godspeed-you

Assignees

@lgetwan lgetwan

Labels
documentation Improvements or additions to documentation enhancement New feature or request lookup:rule This affects the lookup module 'rule'. lookup:rules This affects the lookup module 'rules'. lookup:ruleset This affects the lookup module 'ruleset'. lookup:rulesets This affects the lookup module 'rulesets'. release:4.1.0 Affects the mentioned release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgetwan @robin-checkmk