Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Vagrantfile for KVM #493

Merged
merged 11 commits into from
Dec 20, 2023
Merged

Added Vagrantfile for KVM #493

merged 11 commits into from
Dec 20, 2023

Conversation

Max-checkmk
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Vagrantfile for tests is only for VirtualBox

What is the new behavior?

Added another vagrantfile for kvm setups

Other information

  • Only tested the VM "collection"
  • No libvirt vagrantbox for sles found

@Max-checkmk Max-checkmk added the enhancement New feature or request label Dec 7, 2023
@Max-checkmk Max-checkmk self-assigned this Dec 7, 2023
robin-checkmk
robin-checkmk reviewed Dec 8, 2023
View reviewed changes
Vagrantfile.kvm Outdated Show resolved Hide resolved
Vagrantfile.kvm Outdated Show resolved Hide resolved
Vagrantfile.kvm Outdated Show resolved Hide resolved
@robin-checkmk
Copy link
Member

ToDos @robin-checkmk:

  • Put Vagrantfile in .gitignore
  • Create logic to use Vagrantfiles conditionally
  • Reintroduce membacking for proper shared folder support

@robin-checkmk robin-checkmk mentioned this pull request Dec 20, 2023
Merged
7 tasks
@robin-checkmk robin-checkmk merged commit 69dafed into devel Dec 20, 2023
5 checks passed
@robin-checkmk robin-checkmk deleted the Vagrantfile_kvm branch December 20, 2023 16:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
@robin-checkmk robin-checkmk added the release:4.1.0 Affects the mentioned release. label Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robin-checkmk robin-checkmk robin-checkmk approved these changes

Assignees

@Max-checkmk Max-checkmk

Labels
enhancement New feature or request release:4.1.0 Affects the mentioned release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Max-checkmk @robin-checkmk