Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The rule module has now a parameter rule_id #508

Merged
merged 27 commits into from
Feb 16, 2024
Merged

The rule module has now a parameter rule_id #508

merged 27 commits into from
Feb 16, 2024

Conversation

lgetwan
Copy link
Contributor

@lgetwan lgetwan commented Dec 20, 2023

The rule module has now a parameter rule_id that can be used to identify an existing rule.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • It was not possible to delete a rule with a known rule_id
  • It was not possible to modify existing rules, at all

What is the new behavior?

  • When a rule_id is given, the user can delete or modify the rule

Other information

@github-actions github-actions bot added the module:rule This affects the rule module label Dec 20, 2023
@lgetwan
Copy link
Contributor Author

lgetwan commented Dec 20, 2023

TODO:
Deleting already works, but modifying rules is not yet supported.

This was referenced Dec 28, 2023
Merged
Merged
@github-actions github-actions bot added documentation Improvements or additions to documentation role:server This affects the server role role:agent This affects the agent role module:password This affects the password module labels Jan 19, 2024
@lgetwan lgetwan marked this pull request as ready for review January 23, 2024 08:45
@github-actions github-actions bot added module:host_group This affects the host_group module module:tag_group This affects the tag_group module module:user This affects the user module labels Jan 23, 2024
@lgetwan
Copy link
Contributor Author

lgetwan commented Jan 24, 2024

This PR is now ready for a review.

@robin-checkmk robin-checkmk added release:4.3.0 Affects the mentioned release. and removed role:server This affects the server role role:agent This affects the agent role module:host_group This affects the host_group module module:tag_group This affects the tag_group module module:user This affects the user module module:password This affects the password module labels Jan 25, 2024
@robin-checkmk robin-checkmk mentioned this pull request Feb 15, 2024
Merged
7 tasks
@robin-checkmk robin-checkmk merged commit 2557900 into devel Feb 16, 2024
26 checks passed
@robin-checkmk robin-checkmk deleted the feature/module-rules-rule_id branch February 16, 2024 12:52
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Max-checkmk Max-checkmk Awaiting requested review from Max-checkmk

@godspeed-you godspeed-you Awaiting requested review from godspeed-you

@robin-checkmk robin-checkmk Awaiting requested review from robin-checkmk robin-checkmk is a code owner

Assignees

@lgetwan lgetwan

Labels
documentation Improvements or additions to documentation module:rule This affects the rule module release:4.3.0 Affects the mentioned release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgetwan @robin-checkmk