-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature parse parents attribute as list #545
Feature parse parents attribute as list #545
Conversation
this PR can be merged right away, before #536 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change also seems to be picked into your other PR #539. I reviewed it there, but it looks slightly different, there: You're using a list FOLDER_PARENTS_PARSE, there, which even looks better.
I'm not sure how to solve this without messing with git.
This PR should be merged after #539. When doing this, we might get a minor merge conflict in the folder.py, but never mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this, Michael!
Improve Fix/Solve #515
Pull request type
if
parents
attribute is provided inattributes
orupdate_attributes
of host or folder module parses files as listWhat is the current behavior?
#515
if one provides
parents: test
it would be parsed as ['t', 'e', 's', 't'] (becauseparents
awaits list as a parameter)now it will be parsed as ['test']
What is the new behavior?
parents
gets a string (or some other type) as a parameter ansible utils will take care that it will be interpreted as a listOther information