Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make discovery module compatible to Checkmk 2.4.0. #716

Open
wants to merge 4 commits into
base: build/checkmk-24-support
Choose a base branch
from

Conversation

lgetwan
Copy link
Contributor

@lgetwan lgetwan commented Jan 24, 2025

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #709

What is the new behavior?

  • In versions 2.4.0 and newer, the modes tabula_rasa and refresh are no longer available,
    in that case, we perform a add/remove all services and labels, instead.

Other information

The API parameter mode is gone for the bulk discovery endpoint in Checkmk 2.4.0. In 2.3.0 it was already deprecated. Instead, the parameter "mode" was introduced. Thus, we use this mapping:

State monitor_undecided_services remove_vanished_services update_service_labels update_host_labels
new X X
fix_all X X X
monitor_undecided_services X
refresh X X X X
tabula_rasa X X X X
only_service_labels X
only_host_labels X
remove X

@lgetwan lgetwan requested a review from Max-checkmk as a code owner January 24, 2025 08:37
@github-actions github-actions bot added the module:discovery This affects the discovery module label Jan 24, 2025
@lgetwan lgetwan requested review from robin-checkmk and removed request for Max-checkmk January 24, 2025 12:04
@lgetwan lgetwan self-assigned this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:discovery This affects the discovery module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant