Skip to content

Commit

Permalink
Reapply "Add markdown to root Pipfile"
Browse files Browse the repository at this point in the history
This reverts commit 0d9d877.

As long as we make these calls during build without the help of bazel,
we need to keep markdown in the top level Pipfile.

> git grep '\--filter-by-edition'
cmk/utils/werks/__main__.py:        "--filter-by-edition",
omd/packages/check_mk/check_mk.make:        $(PACKAGE_PYTHON3_MODULES_PYTHON) -m cmk.utils.werks precompile $(REPO_PATH)/.werks $@ --filter-by-edition cre
omd/packages/cloud/cloud.make:      $(PACKAGE_PYTHON3_MODULES_PYTHON) -m cmk.utils.werks precompile $(REPO_PATH)/.werks $@ --filter-by-edition cce
omd/packages/enterprise/enterprise.make:            $(PACKAGE_PYTHON3_MODULES_PYTHON) -m cmk.utils.werks precompile $(REPO_PATH)/.werks $@ --filter-by-edition cee
omd/packages/managed/managed.make:          $(PACKAGE_PYTHON3_MODULES_PYTHON) -m cmk.utils.werks precompile $(REPO_PATH)/.werks $@ --filter-by-edition cme
omd/packages/saas/saas.make:        $(PACKAGE_PYTHON3_MODULES_PYTHON) -m cmk.utils.werks precompile $(REPO_PATH)/.werks $@ --filter-by-edition cse

Change-Id: I05f56380eed6cd7b7795fad4b04562ca73148be0
  • Loading branch information
LarsMichelsen committed Oct 24, 2024
1 parent 2adf156 commit 59e3117
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ uvicorn = "*"
webtest = "*" # used by WSGI based tests

[packages]
markdown = "*" # Should be in cmk-werks, see CMK-19819
setuptools = "<=70.3.0" # See https://github.com/pypa/setuptools/issues/4487#issuecomment-2237487845 for context
setuptools-scm = "==4.1.2" # needed by various setup.py
six = "==1.16.0" # direct dependency + needed by python-dateutil, vcrpy, python-active-directory
Expand Down
3 changes: 2 additions & 1 deletion Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions tests/code_quality/test_pipfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,8 @@ def get_undeclared_dependencies() -> Iterable[Import]:
def test_dependencies_are_used() -> None:
known_unused_packages = set(CEE_UNUSED_PACKAGES)
known_unused_packages.add("setuptools") # pinned transitive dependency
known_unused_packages.add("markdown") # Should be in cmk-werks, see CMK-19819

if not is_enterprise_repo():
known_unused_packages.update(("PyPDF", "numpy", "roman"))

Expand Down

0 comments on commit 59e3117

Please sign in to comment.