legacy checks: 'maincheckify' the check names

Add the 'maincheckified' names to the check definitions.
That way we can soon remove 'maincheckify'.

Change-Id: Iadabc9d77413132dd0be2321387db342aeb2f7e3

cmk/base/config.py

@@ -1494,7 +1494,9 @@ def load_checks(
             " -- this API is deprecated!"
         )
 
-    legacy_check_plugin_names.update({CheckPluginName(maincheckify(n)): n for n in sane_check_info})
+    legacy_check_plugin_names.update(
+        {CheckPluginName(lcd.name): n for n, lcd in sane_check_info.items()}
+    )
 
     section_errors, sections = _make_agent_and_snmp_sections(sane_check_info)
     check_errors, checks = _make_check_plugins(

cmk/base/legacy_checks/3ware_disks.py

@@ -85,6 +85,7 @@ def parse_3ware_disks(string_table: StringTable) -> StringTable:
 
 
 check_info["3ware_disks"] = LegacyCheckDefinition(
+    name="3ware_disks",
     parse_function=parse_3ware_disks,
     service_name="RAID 3ware disk %s",
     discovery_function=inventory_3ware_disks,

cmk/base/legacy_checks/3ware_info.py

@@ -51,6 +51,7 @@ def parse_3ware_info(string_table: StringTable) -> StringTable:
 
 
 check_info["3ware_info"] = LegacyCheckDefinition(
+    name="3ware_info",
     parse_function=parse_3ware_info,
     service_name="RAID 3ware controller %s",
     discovery_function=inventory_3ware_info,

cmk/base/legacy_checks/3ware_units.py

@@ -71,6 +71,7 @@ def parse_3ware_units(string_table: StringTable) -> StringTable:
 
 
 check_info["3ware_units"] = LegacyCheckDefinition(
+    name="3ware_units",
     parse_function=parse_3ware_units,
     service_name="RAID 3ware unit %s",
     discovery_function=inventory_3ware_units,

cmk/base/legacy_checks/acme_certificates.py

@@ -63,6 +63,7 @@ def parse_acme_certificates(string_table: StringTable) -> StringTable:
 
 
 check_info["acme_certificates"] = LegacyCheckDefinition(
+    name="acme_certificates",
     parse_function=parse_acme_certificates,
     detect=DETECT_ACME,
     fetch=SNMPTree(

cmk/base/legacy_checks/acme_fan.py

@@ -40,6 +40,7 @@ def parse_acme_fan(string_table: StringTable) -> StringTable:
 
 
 check_info["acme_fan"] = LegacyCheckDefinition(
+    name="acme_fan",
     parse_function=parse_acme_fan,
     detect=DETECT_ACME,
     fetch=SNMPTree(

cmk/base/legacy_checks/acme_powersupply.py

@@ -33,6 +33,7 @@ def parse_acme_powersupply(string_table: StringTable) -> StringTable:
 
 
 check_info["acme_powersupply"] = LegacyCheckDefinition(
+    name="acme_powersupply",
     parse_function=parse_acme_powersupply,
     detect=DETECT_ACME,
     fetch=SNMPTree(

cmk/base/legacy_checks/acme_sbc_snmp.py

@@ -62,6 +62,7 @@ def parse_acme_sbc_snmp(string_table: StringTable) -> StringTable | None:
 
 
 check_info["acme_sbc_snmp"] = LegacyCheckDefinition(
+    name="acme_sbc_snmp",
     parse_function=parse_acme_sbc_snmp,
     detect=DETECT_ACME,
     fetch=SNMPTree(

cmk/base/legacy_checks/acme_temp.py

@@ -60,6 +60,7 @@ def parse_acme_temp(string_table: StringTable) -> StringTable:
 
 
 check_info["acme_temp"] = LegacyCheckDefinition(
+    name="acme_temp",
     parse_function=parse_acme_temp,
     detect=DETECT_ACME,
     fetch=SNMPTree(

cmk/base/legacy_checks/acme_voltage.py

@@ -76,6 +76,7 @@ def parse_acme_voltage(string_table: StringTable) -> StringTable:
 
 
 check_info["acme_voltage"] = LegacyCheckDefinition(
+    name="acme_voltage",
     parse_function=parse_acme_voltage,
     detect=DETECT_ACME,
     fetch=SNMPTree(

cmk/base/legacy_checks/ad_replication.py

@@ -183,6 +183,7 @@ def parse_ad_replication(string_table: StringTable) -> StringTable:
 
 
 check_info["ad_replication"] = LegacyCheckDefinition(
+    name="ad_replication",
     parse_function=parse_ad_replication,
     service_name="AD Replication %s",
     discovery_function=inventory_ad_replication,

cmk/base/legacy_checks/adva_fsp_temp.py

@@ -51,6 +51,7 @@ def parse_adva_fsp_temp(string_table: StringTable) -> StringTable:
 
 
 check_info["adva_fsp_temp"] = LegacyCheckDefinition(
+    name="adva_fsp_temp",
     parse_function=parse_adva_fsp_temp,
     detect=equals(".1.3.6.1.2.1.1.1.0", "Fiber Service Platform F7"),
     fetch=SNMPTree(

cmk/base/legacy_checks/aironet_errors.py

@@ -49,6 +49,7 @@ def parse_aironet_errors(string_table: StringTable) -> StringTable:
 
 
 check_info["aironet_errors"] = LegacyCheckDefinition(
+    name="aironet_errors",
     parse_function=parse_aironet_errors,
     detect=any_of(
         equals(".1.3.6.1.2.1.1.2.0", ".1.3.6.1.4.1.9.1.525"),

cmk/base/legacy_checks/aix_hacmp_resources.py

@@ -66,6 +66,7 @@ def check_aix_hacmp_resources(item, params, parsed):
 
 
 check_info["aix_hacmp_resources"] = LegacyCheckDefinition(
+    name="aix_hacmp_resources",
     parse_function=parse_aix_hacmp_resources,
     service_name="HACMP RG %s",
     discovery_function=inventory_aix_hacmp_resources,

cmk/base/legacy_checks/aix_paging.py

@@ -65,6 +65,7 @@ def discover_aix_paging(section):
 
 
 check_info["aix_paging"] = LegacyCheckDefinition(
+    name="aix_paging",
     parse_function=parse_aix_paging,
     service_name="Page Space %s",
     discovery_function=discover_aix_paging,

cmk/base/legacy_checks/akcp_daisy_temp.py

@@ -44,6 +44,7 @@ def parse_akcp_daisy_temp(string_table: Sequence[StringTable]) -> Sequence[Strin
 
 
 check_info["akcp_daisy_temp"] = LegacyCheckDefinition(
+    name="akcp_daisy_temp",
     parse_function=parse_akcp_daisy_temp,
     detect=all_of(
         any_of(

cmk/base/legacy_checks/alcatel_temp.py

@@ -44,6 +44,7 @@ def check_alcatel_temp(item, params, info):
 
 
 check_info["alcatel_temp"] = LegacyCheckDefinition(
+    name="alcatel_temp",
     parse_function=parse_alcatel_temp,
     detect=DETECT_ALCATEL,
     fetch=SNMPTree(

cmk/base/legacy_checks/alcatel_temp_aos7.py

@@ -56,6 +56,7 @@ def discover_alcatel_temp_aos7(section):
 
 
 check_info["alcatel_temp_aos7"] = LegacyCheckDefinition(
+    name="alcatel_temp_aos7",
     detect=DETECT_ALCATEL_AOS7,
     fetch=SNMPTree(
         base=".1.3.6.1.4.1.6486.801.1.1.1.3.1.1.3.1",

cmk/base/legacy_checks/alcatel_timetra_cpu.py

@@ -25,6 +25,7 @@ def parse_alcatel_timetra_cpu(string_table: StringTable) -> StringTable | None:
 
 
 check_info["alcatel_timetra_cpu"] = LegacyCheckDefinition(
+    name="alcatel_timetra_cpu",
     parse_function=parse_alcatel_timetra_cpu,
     detect=contains(".1.3.6.1.2.1.1.1.0", "TiMOS"),
     fetch=SNMPTree(

cmk/base/legacy_checks/allnet_ip_sensoric.py

@@ -102,6 +102,7 @@ def check_allnet_ip_sensoric_tension(item, _no_params, parsed):
 
 
 check_info["allnet_ip_sensoric.tension"] = LegacyCheckDefinition(
+    name="allnet_ip_sensoric_tension",
     # section already migrated!
     service_name="Electric Tension %s",
     sections=["allnet_ip_sensoric"],
@@ -140,6 +141,7 @@ def check_allnet_ip_sensoric_temp(item, params, parsed):
 
 
 check_info["allnet_ip_sensoric.temp"] = LegacyCheckDefinition(
+    name="allnet_ip_sensoric_temp",
     # section already migrated!
     service_name="Temperature %s",
     sections=["allnet_ip_sensoric"],
@@ -177,6 +179,7 @@ def check_allnet_ip_sensoric_humidity(item, params, parsed):
 
 
 check_info["allnet_ip_sensoric.humidity"] = LegacyCheckDefinition(
+    name="allnet_ip_sensoric_humidity",
     # section already migrated!
     service_name="Humidity %s",
     sections=["allnet_ip_sensoric"],
@@ -222,6 +225,7 @@ def check_allnet_ip_sensoric_pressure(item, _no_params, parsed):
 
 
 check_info["allnet_ip_sensoric.pressure"] = LegacyCheckDefinition(
+    name="allnet_ip_sensoric_pressure",
     # section already migrated!
     service_name="Pressure %s",
     sections=["allnet_ip_sensoric"],

cmk/base/legacy_checks/apc_ats_output.py

@@ -67,6 +67,7 @@ def check_apc_ats_output(item, params, parsed):
 
 
 check_info["apc_ats_output"] = LegacyCheckDefinition(
+    name="apc_ats_output",
     detect=DETECT_ATS,
     fetch=SNMPTree(
         base=".1.3.6.1.4.1.318.1.1.8.5.4.3.1",

cmk/base/legacy_checks/apc_ats_status.py

@@ -85,6 +85,7 @@ def check_apc_ats_status(_no_item: Any, params: dict, parsed: Status) -> Iterabl
 
 
 check_info["apc_ats_status"] = LegacyCheckDefinition(
+    name="apc_ats_status",
     parse_function=parse_apc_ats_status,
     detect=DETECT_ATS,
     fetch=SNMPTree(

cmk/base/legacy_checks/apc_humidity.py

@@ -43,6 +43,7 @@ def parse_apc_humidity(string_table: StringTable) -> StringTable:
 
 
 check_info["apc_humidity"] = LegacyCheckDefinition(
+    name="apc_humidity",
     parse_function=parse_apc_humidity,
     detect=DETECT,
     fetch=SNMPTree(

cmk/base/legacy_checks/apc_inrow_airflow.py

@@ -53,6 +53,7 @@ def parse_apc_inrow_airflow(string_table: StringTable) -> StringTable:
 
 
 check_info["apc_inrow_airflow"] = LegacyCheckDefinition(
+    name="apc_inrow_airflow",
     parse_function=parse_apc_inrow_airflow,
     detect=DETECT,
     fetch=SNMPTree(

cmk/base/legacy_checks/apc_inrow_temp.py

@@ -45,6 +45,7 @@ def check_apc_inrow_temp(item, params, parsed):
 
 
 check_info["apc_inrow_temp"] = LegacyCheckDefinition(
+    name="apc_inrow_temp",
     detect=DETECT,
     fetch=SNMPTree(
         base=".1.3.6.1.4.1.318.1.1.13.3.2.2.2",

cmk/base/legacy_checks/apc_rackpdu_power.py

@@ -14,6 +14,7 @@ def discover_apc_rackpdu_power(section):
 
 
 check_info["apc_rackpdu_power"] = LegacyCheckDefinition(
+    name="apc_rackpdu_power",
     service_name="PDU %s",
     discovery_function=discover_apc_rackpdu_power,
     check_function=check_elphase,

cmk/base/legacy_checks/apc_sts_inputs.py

@@ -54,6 +54,7 @@ def discover_apc_sts_inputs(section):
 
 
 check_info["apc_sts_inputs"] = LegacyCheckDefinition(
+    name="apc_sts_inputs",
     detect=contains(".1.3.6.1.2.1.1.2.0", ".1.3.6.1.4.1.705.2.2"),
     fetch=[
         SNMPTree(

cmk/base/legacy_checks/apc_symmetra.py

@@ -284,6 +284,7 @@ def check_apc_symmetra(_no_item, params, parsed):  # pylint: disable=too-many-br
 
 
 check_info["apc_symmetra"] = LegacyCheckDefinition(
+    name="apc_symmetra",
     detect=DETECT,
     fetch=[
         SNMPTree(
@@ -352,6 +353,7 @@ def check_apc_symmetra_temp(item, params, parsed):
 
 
 check_info["apc_symmetra.temp"] = LegacyCheckDefinition(
+    name="apc_symmetra_temp",
     service_name="Temperature %s",
     sections=["apc_symmetra"],
     discovery_function=inventory_apc_symmetra_temp,
@@ -386,6 +388,7 @@ def check_apc_symmetra_elphase(item, params, parsed):
 
 
 check_info["apc_symmetra.elphase"] = LegacyCheckDefinition(
+    name="apc_symmetra_elphase",
     service_name="Phase %s",
     sections=["apc_symmetra"],
     discovery_function=inventory_apc_symmetra_elphase,

cmk/base/legacy_checks/apc_symmetra_ext_temp.py

@@ -34,6 +34,7 @@ def parse_apc_symmetra_ext_temp(string_table: StringTable) -> StringTable:
 
 
 check_info["apc_symmetra_ext_temp"] = LegacyCheckDefinition(
+    name="apc_symmetra_ext_temp",
     parse_function=parse_apc_symmetra_ext_temp,
     detect=DETECT,
     fetch=SNMPTree(

cmk/base/legacy_checks/apc_symmetra_input.py

@@ -29,6 +29,7 @@ def discover_apc_symmetra_input(section):
 
 
 check_info["apc_symmetra_input"] = LegacyCheckDefinition(
+    name="apc_symmetra_input",
     detect=DETECT,
     fetch=SNMPTree(
         base=".1.3.6.1.4.1.318.1.1.1.3.2",

cmk/base/legacy_checks/apc_symmetra_output.py

@@ -39,6 +39,7 @@ def discover_apc_symmetra_output(section):
 
 
 check_info["apc_symmetra_output"] = LegacyCheckDefinition(
+    name="apc_symmetra_output",
     detect=DETECT,
     fetch=SNMPTree(
         base=".1.3.6.1.4.1.318.1.1.1.4.2",

cmk/base/legacy_checks/apc_symmetra_test.py

@@ -115,6 +115,7 @@ def parse_apc_symmetra_test(string_table: StringTable) -> StringTable:
 
 
 check_info["apc_symmetra_test"] = LegacyCheckDefinition(
+    name="apc_symmetra_test",
     parse_function=parse_apc_symmetra_test,
     detect=DETECT,
     fetch=SNMPTree(

cmk/base/legacy_checks/appdynamics_memory.py

@@ -111,6 +111,7 @@ def parse_appdynamics_memory(string_table: StringTable) -> StringTable:
 
 
 check_info["appdynamics_memory"] = LegacyCheckDefinition(
+    name="appdynamics_memory",
     parse_function=parse_appdynamics_memory,
     service_name="AppDynamics Memory %s",
     discovery_function=inventory_appdynamics_memory,

cmk/base/legacy_checks/appdynamics_sessions.py

@@ -61,6 +61,7 @@ def parse_appdynamics_sessions(string_table: StringTable) -> StringTable:
 
 
 check_info["appdynamics_sessions"] = LegacyCheckDefinition(
+    name="appdynamics_sessions",
     parse_function=parse_appdynamics_sessions,
     service_name="AppDynamics Sessions %s",
     discovery_function=inventory_appdynamics_sessions,

cmk/base/legacy_checks/appdynamics_web_container.py

@@ -105,6 +105,7 @@ def check_appdynamics_web_container(
 
 
 check_info["appdynamics_web_container"] = LegacyCheckDefinition(
+    name="appdynamics_web_container",
     service_name="AppDynamics Web Container %s",
     parse_function=parse_appdynamics_web_container,
     discovery_function=discover_appdynamics_web_container,

cmk/base/legacy_checks/arris_cmts_cpu.py

@@ -48,6 +48,7 @@ def parse_arris_cmts_cpu(string_table: StringTable) -> StringTable:
 
 
 check_info["arris_cmts_cpu"] = LegacyCheckDefinition(
+    name="arris_cmts_cpu",
     parse_function=parse_arris_cmts_cpu,
     detect=equals(".1.3.6.1.2.1.1.2.0", ".1.3.6.1.4.1.4998.2.1"),
     fetch=SNMPTree(

cmk/base/legacy_checks/arris_cmts_mem.py

@@ -48,6 +48,7 @@ def check_arris_cmts_mem(item, params, parsed):
 
 
 check_info["arris_cmts_mem"] = LegacyCheckDefinition(
+    name="arris_cmts_mem",
     detect=equals(".1.3.6.1.2.1.1.2.0", ".1.3.6.1.4.1.4998.2.1"),
     fetch=SNMPTree(
         base=".1.3.6.1.4.1.4998.1.1.5.3.2.1.1",

cmk/base/legacy_checks/arris_cmts_temp.py

@@ -31,6 +31,7 @@ def parse_arris_cmts_temp(string_table: StringTable) -> StringTable:
 
 
 check_info["arris_cmts_temp"] = LegacyCheckDefinition(
+    name="arris_cmts_temp",
     parse_function=parse_arris_cmts_temp,
     detect=equals(".1.3.6.1.2.1.1.2.0", ".1.3.6.1.4.1.4998.2.1"),
     fetch=SNMPTree(

cmk/base/legacy_checks/artec_temp.py

@@ -28,6 +28,7 @@ def parse_artec_temp(string_table: StringTable) -> StringTable | None:
 
 
 check_info["artec_temp"] = LegacyCheckDefinition(
+    name="artec_temp",
     parse_function=parse_artec_temp,
     detect=all_of(
         equals(".1.3.6.1.2.1.1.2.0", ".1.3.6.1.4.1.8072.3.2.10"),

cmk/base/legacy_checks/aruba_cpu_util.py

@@ -37,6 +37,7 @@ def discover_aruba_cpu_util(section):
 
 
 check_info["aruba_cpu_util"] = LegacyCheckDefinition(
+    name="aruba_cpu_util",
     detect=startswith(".1.3.6.1.2.1.1.2.0", ".1.3.6.1.4.1.14823"),
     fetch=SNMPTree(
         base=".1.3.6.1.4.1.14823.2.2.1.1.1.9.1",

cmk/base/legacy_checks/atto_fibrebridge_chassis.py

@@ -54,6 +54,7 @@ def check_atto_fibrebridge_chassis_temp(item, params, parsed):
 
 
 check_info["atto_fibrebridge_chassis.temp"] = LegacyCheckDefinition(
+    name="atto_fibrebridge_chassis_temp",
     service_name="Temperature %s",
     sections=["atto_fibrebridge_chassis"],
     discovery_function=inventory_atto_fibrebridge_chassis_temp,
@@ -86,6 +87,7 @@ def check_atto_fibrebridge_chassis(_no_item, _no_params, parsed):
 
 
 check_info["atto_fibrebridge_chassis"] = LegacyCheckDefinition(
+    name="atto_fibrebridge_chassis",
     detect=startswith(".1.3.6.1.2.1.1.2.0", ".1.3.6.1.4.1.4547"),
     fetch=SNMPTree(
         base=".1.3.6.1.4.1.4547.2.3.2",

cmk/base/legacy_checks/atto_fibrebridge_fcport.py

@@ -40,6 +40,7 @@ def parse_atto_fibrebridge_fcport(string_table: StringTable) -> StringTable:
 
 
 check_info["atto_fibrebridge_fcport"] = LegacyCheckDefinition(
+    name="atto_fibrebridge_fcport",
     parse_function=parse_atto_fibrebridge_fcport,
     detect=startswith(".1.3.6.1.2.1.1.2.0", ".1.3.6.1.4.1.4547"),
     fetch=SNMPTree(

cmk/base/legacy_checks/avaya_45xx_cpu.py

@@ -31,6 +31,7 @@ def parse_avaya_45xx_cpu(string_table: StringTable) -> StringTable:
 
 
 check_info["avaya_45xx_cpu"] = LegacyCheckDefinition(
+    name="avaya_45xx_cpu",
     parse_function=parse_avaya_45xx_cpu,
     detect=contains(".1.3.6.1.2.1.1.2.0", ".1.3.6.1.4.1.45.3"),
     fetch=SNMPTree(