Skip to content

Commit

Permalink
Redfish integration tests: Discard stdout of Redfish mock servers
Browse files Browse the repository at this point in the history
These mock servers produce a lot of stdout, causing buffering issues. Since we
anyway don't use it, we might as well discard it. Note that these buffering
issues did not cause any test failures (since calling the mock servers at least
once worked), but avoiding them is of course more correct.

Change-Id: I4720673d8d816ec726efa46579782b79eb0a6072
  • Loading branch information
jherbel committed Jan 22, 2025
1 parent e70be41 commit b8bc0f3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/integration_redfish/lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def create_special_agent_rule(
def run_mockup_server(*, dataset_path: Path, port: int) -> subprocess.Popen:
return subprocess.Popen(
["python3", _MOCKUP_SERVER_FILE, "--port", f"{port}", "-D", dataset_path],
stdout=subprocess.PIPE,
stdout=subprocess.DEVNULL,
stderr=subprocess.PIPE,
text=True,
)
Expand Down

0 comments on commit b8bc0f3

Please sign in to comment.