migration helper: handle discovery rules

Change-Id: Ice0a04cb161808dd8b8ec1fcad7c011c112648e7
Checkmk · Jan 31, 2025 · c335521 · c335521
1 parent b5062e2
commit c335521
Showing 1 changed file with 37 additions and 3 deletions.
diff --git a/doc/treasures/migration_helpers/legacy_vs_to_ruleset_v1.py b/doc/treasures/migration_helpers/legacy_vs_to_ruleset_v1.py
@@ -432,13 +432,20 @@ def _make_ruleset_plugin(self, old_ruleset: cst.Call) -> cst.SimpleStatementLine
             return self._construct_check_parameters(old_ruleset.args)
 
         args = {k.value: arg.value for arg in old_ruleset.args if (k := arg.keyword) is not None}
-        group = cst.ensure_type(
-            cst.ensure_type(args["name"], cst.Call).func, cst.Attribute
-        ).attr.value
+        group = (
+            name.value
+            if isinstance(name := args["name"], cst.SimpleString)
+            else cst.ensure_type(
+                cst.ensure_type(args["name"], cst.Call).func, cst.Attribute
+            ).attr.value
+        )
         if rule_type == "HostRulespec" and group == "SpecialAgents":
             return self._construct_special_agent(old_ruleset.args)
         if rule_type == "HostRulespec" and group == "ActiveChecks":
             return self._construct_active_check(old_ruleset.args)
+        if rule_type == "HostRulespec":
+            # a guess, but most of the time it's a discovery rule
+            return self._construct_discovery_parameters(group, old_ruleset.args)
 
         print(f"not yet implemented rulespec type: {rule_type}", file=sys.stderr)
         return cst.SimpleStatementLine(
@@ -476,6 +483,33 @@ def _construct_check_parameters(self, old: Sequence[cst.Arg]) -> cst.SimpleState
             )
         )
 
+    def _construct_discovery_parameters(
+        self, name: str, old: Sequence[cst.Arg]
+    ) -> cst.SimpleStatementLine:
+        args = {k.value: arg.value for arg in old if (k := arg.keyword) is not None}
+        form_spec = args["parameter_valuespec"]
+
+        return cst.SimpleStatementLine(
+            (
+                cst.Assign(
+                    targets=(cst.AssignTarget(cst.Name(f"rule_spec_{name}")),),
+                    value=cst.Call(
+                        func=cst.Name("DiscoveryParameters"),
+                        args=(
+                            cst.Arg(cst.SimpleString(f'"{name}"'), cst.Name("name")),
+                            *_extract("title", old),
+                            cst.Arg(cst.Name("Topic"), cst.Name("topic")),
+                            cst.Arg(form_spec, cst.Name("parameter_form")),
+                            cst.Arg(
+                                self._make_condition(args.get("item_spec")),
+                                cst.Name("condition"),
+                            ),
+                        ),
+                    ),
+                ),
+            )
+        )
+
     def _construct_active_check(self, old: Sequence[cst.Arg]) -> cst.SimpleStatementLine:
         args = {k.value: arg.value for arg in old if (k := arg.keyword) is not None}
         name = self._extract_string(cst.ensure_type(args["name"], cst.Call).args[0].value)