Decommission agent_based_api.v1: completely remove

We still keep the implementation at cmk.agent_based.v0
(as it is reused in v2), but this removes its exposure
under cmk.base.

Change-Id: I150700c6b6a29d013d306cc6a7bdced573a213cf

packages/cmk-agent-based/tests/cmk/agent_based/test_v1_namespace.py

@@ -25,7 +25,6 @@ def _names(space: ModuleType) -> set[str]:
 def test_v1() -> None:
     expected = {
         # value_store: not explicitly exposed here,
-        # not at all exposed in the old location under cmk/base/plugins/agent_based/agent_based/api
         "value_store",
         # register: only partially in this package, b/c that is not how we're doing things anymore.
         "register",

tests/pylint/checker_cmk_module_layers.py

@@ -400,23 +400,6 @@ def _allow_for_cmk_update_config(
     )
 
 
-def _is_allowed_for_agent_based_api_exposure_under_plugins(
-    *,
-    imported: ModuleName,
-    component: Component,  # pylint: disable=unused-argument
-) -> bool:
-    return any(
-        (
-            _in_component(imported=imported, component=Component("cmk.agent_based.v1")),
-            _in_component(imported=imported, component=Component("cmk.base.api.agent_based")),
-            _in_component(
-                imported=imported,
-                component=Component("cmk.base.plugins.agent_based.agent_based_api"),
-            ),
-        )
-    )
-
-
 def _is_allowed_for_plugins(
     *,
     imported: ModuleName,
@@ -478,33 +461,13 @@ def _is_allowed_for_robotmk_rulesets_cee_plugins(
     )
 
 
-def _is_allowed_for_agent_based_plugin(
-    *,
-    imported: ModuleName,
-    component: Component,  # pylint: disable=unused-argument
-) -> bool:
-    return any(
-        (
-            _in_component(
-                imported=imported,
-                component=Component("cmk.base.plugins.agent_based.agent_based_api"),
-            ),
-            _in_component(
-                imported=imported,
-                component=Component("cmk.base.plugins.agent_based.utils"),
-            ),
-            _in_component(imported=imported, component=Component("cmk.plugins")),
-        )
-    )
-
-
 def _allow_default_plus_component_under_test(
     *,
     imported: ModuleName,
     component: Component,
 ) -> bool:
     if component.startswith("tests.unit.checks"):
-        component_under_test = Component("cmk.base.plugins.agent_based")
+        component_under_test = Component("cmk.plugins")
     elif component.startswith("tests.unit.") or component.startswith("tests.integration"):
         component_under_test = Component(".".join(component.split(".")[2:]))
     else:
@@ -655,11 +618,6 @@ def _allow_for_cmk_piggyback_hub(
     (Component("cmk.base.api.agent_based"), _allow_default_plus_fetchers_checkers_and_snmplib),
     (Component("cmk.base.check_legacy_includes"), _is_allowed_for_legacy_checks),
     (Component("cmk.base.legacy_checks"), _is_allowed_for_legacy_checks),
-    (
-        Component("cmk.base.plugins.agent_based.agent_based_api"),
-        _is_allowed_for_agent_based_api_exposure_under_plugins,
-    ),
-    (Component("cmk.base.plugins.agent_based"), _is_allowed_for_agent_based_plugin),
     # importing config in ip_lookup repeatedly lead to import cycles. It's cleanup now.
     (Component("cmk.base.ip_lookup"), _is_default_allowed_import),
     (Component("cmk.base"), _allowed_for_base_cee),