Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-2282 Improve some coins checks in test_select_coins_rpc #19206

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

Improve checking min_coins, max_coins and excluded_amt_coins in test_select_coins_rpc and don't test them against None as they're lists.

Current Behavior:

We check these lists against None and then perform additional tests on them.

New Behavior:

Perform length and content tests without checking for None beforehand.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Jan 29, 2025
@AmineKhaldi AmineKhaldi self-assigned this Jan 29, 2025
@AmineKhaldi AmineKhaldi changed the title Improve some coins checks in test_select_coins_rpc CHIA-2282 Improve some coins checks in test_select_coins_rpc Jan 29, 2025
Copy link

Pull Request Test Coverage Report for Build 13029956340

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.04%) to 91.545%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/util/config.py 1 84.62%
chia/plotters/plotters.py 1 90.94%
chia/rpc/rpc_server.py 1 88.54%
chia/full_node/full_node.py 1 86.54%
chia/server/node_discovery.py 2 81.14%
chia/plotters/madmax.py 6 44.58%
Totals Coverage Status
Change from base Build 13019247618: 0.04%
Covered Lines: 105298
Relevant Lines: 114850

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants