Disable FF with amount related conditions and relative timelocks #942
+46
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13520590624Details
💛 - Coveralls |
arvidn
requested changes
Feb 24, 2025
Comment on lines
117
to
118
| | Condition::AssertHeightRelative(_) | ||
| | Condition::AssertSecondsRelative(_) => { |
There was a problem hiding this comment.
These two should not clear the ELIGIBLE_FOR_DEDUP flag, should they?
I believe you should also check AssertEphemeral here. It's considered a relative-timelock.
Also ASSERT_BEFORE_SECONDS_RELATIVE, ASSERT_BEFORE_HEIGHT_RELATIVE, ASSERT_MY_BIRTH_HEIGHT , ASSERT_MY_BIRTH_SECONDS. I think that's it
There was a problem hiding this comment.
Ephemeral and Before conditions are not affected by the fastforward - good catch with the birth height and birth seconds though, I've added those now
| @@ -4070,7 +4091,8 @@ fn test_impossible_constraints_single_spend( | |||
| } else { | |||
| // we don't expect any error | |||
| let (a, conds) = cond_test(test).unwrap(); | |||
|
|
|||
| let banned_list = [ASSERT_SECONDS_RELATIVE, ASSERT_HEIGHT_RELATIVE]; | |||
There was a problem hiding this comment.
I think this list needs to be longer
arvidn
reviewed
Feb 25, 2025
arvidn
reviewed
Feb 25, 2025
arvidn
reviewed
Feb 25, 2025
This reverts commit 78a262c.
matt-o-how
force-pushed
the
tighten_ff
branch
from
cf48594 to
c40da6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.