[CHIA-2419] Handle RESERVE_FEE differently with identical spend aggregation #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
reviewed
Feb 26, 2025
| @@ -1540,6 +1542,33 @@ pub fn validate_signature( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub fn check_deduplication(ret: &mut SpendBundleConditions) { | |||
There was a problem hiding this comment.
all other dedup logic is implemented in the MempoolVisitor, to only have it active in mempool mode, and not consensus mode. It seems we create a new visitor for every spend, and it doesn't really have a view of the whole bundle. I think it's worth trying to think of ways to tie this check to the visitor still.
worst case check_deduplication() could be a "static" function in the SpendVisitor trait. but maybe be called something like spend bundle post processing.
| @@ -1540,6 +1542,33 @@ pub fn validate_signature( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub fn check_deduplication(ret: &mut SpendBundleConditions) { | |||
| let mut non_dedup_removal_amount = 0; | |||
| let mut non_dedup_addition_amount = 0; | |||
There was a problem hiding this comment.
it would make me a bit less nervous to specify these types as u64
arvidn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.