Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clvm-traits and bump chia-bls #368

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Remove clvm-traits and bump chia-bls #368

merged 1 commit into from
Feb 2, 2024

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented Feb 2, 2024

There is a circular dependency issue still, whenever we bump clvm-traits. Since the implementations here are for the old version, the new version is a conflict, which causes errors in chia_rs. The simplest path forward is to remove the circular dependency between repos wherever possible. So this reverts a prior change to add it.

This is a breaking change, and to implement it in chia_rs, we will have to add the implementations back, as well as a dependency on clvmr in clvm-traits. This also means that chia-bls cannot depend on clvm-traits since it would indirectly depend on itself in doing so.

@Rigidity Rigidity requested a review from arvidn February 2, 2024 17:30
Copy link

Pull Request Test Coverage Report for Build 7759447098

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 93.6%

Totals Coverage Status
Change from base Build 7726608167: -0.05%
Covered Lines: 5221
Relevant Lines: 5578

💛 - Coveralls

@Rigidity Rigidity merged commit da9b37a into main Feb 2, 2024
29 checks passed
@Rigidity Rigidity deleted the remove-clvm-traits branch February 2, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants