107 redo lock reservation price

app/commands/price_lock_backdater.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+# Copyright 2022 Victoria Garcia*
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This command is run by a rake task during the migration progress.
+# It finds reservations associated with chicago_contacts who requested installment
+# plans.  The pricing structure for upgrades to such a membership is then locked
+# to the date of the request for installment.
+
+class PriceLockBackdater
+  def errors
+    @errors ||= []
+  end
+
+  def call
+    puts "Searching for reservations that qualify for backdated price lock dates. \n"
+
+    qualifying_reservations = NonPricelockedReservationsWithInstallmentRequests.new.call
+    report_string = nil
+
+    if qualifying_reservations.any?
+
+      puts "Attempting to add backdated price lock dates to #{qualifying_reservations.size} reservations:\n\n"
+
+      qualifying_reservations.each_with_index do |qual, i|
+        our_reservation = Reservation.find_by(id: qual.id)
+        new_error = nil
+        new_error =  "Unable to find reservation: #{qual.id}." unless our_reservation
+
+        if !new_error
+          new_error =  "Unable to update reservation with id: #{qual.id}." unless our_reservation.update(price_lock_date:  qual.new_price_lock_date)
+          our_reservation.reload if !new_error
+        end
+
+        puts "Updated reservation #{i}.".indent(5) unless new_error
+        errors << new_error if new_error
+      end
+
+      not_updated = errors.size
+      updated = qualifying_reservations.size - not_updated
+
+      report_string = "\n Successfully updated #{updated} reservations."
+      unless not_updated == 0
+        report_string = report_string + "  Unable to update #{not_updated} qualifying reservation(s). Problem(s) as follows:\n#{errors.join(" \n")}"
+      end
+    else
+      report_string = "\n No reservations that qualifed for backdated price lock dates were found!\n"
+    end
+
+    puts report_string
+    return errors.empty?
+  end
+end

app/commands/upgrade_membership.rb

@@ -31,7 +31,7 @@ def errors
   private
 
   def check_availability
-    prices = UpgradeOffer.from(reservation.membership, target_membership: to_membership)
+    prices = UpgradeOffer.from(reservation.membership,  target_membership: to_membership, for_reservation: reservation)
     if prices.none?
       errors << "#{reservation.membership} cannot upgrade to #{to_membership}"
     end

app/controllers/upgrades_controller.rb

@@ -19,7 +19,7 @@ class UpgradesController < ApplicationController
   before_action :lookup_offer, except: :index
 
   def index
-    all_offers = UpgradeOffer.from(@reservation.membership)
+    all_offers = UpgradeOffer.from(@reservation.membership, for_reservation: @reservation)
     @offers = if support_signed_in?
                 all_offers
               else
@@ -51,7 +51,7 @@ def create
   private
 
   def lookup_offer
-    @my_offer = UpgradeOffer.from(@reservation.membership).find do |offer|
+    @my_offer = UpgradeOffer.from(@reservation.membership, for_reservation: @reservation).find do |offer|
       offer.hash == params[:offer]
     end
 

app/models/claim.rb

@@ -44,6 +44,11 @@ def transferable?
     active_to.nil?
   end
 
+  def requested_installment?
+    return false unless self.contact && self.contact.installment_wanted?
+    self.contact.installment_wanted
+  end
+
   # Sync when claim changes as transfer will cause your rights or default name to change
   after_commit :gloo_sync
   def gloo_lookup_user

app/models/membership.rb

@@ -47,7 +47,7 @@ class Membership < ApplicationRecord
   scope :can_vote, -> { where(can_vote: true) }
 
   scope :dob_required, -> { where(dob_required: true) }
-
+  scope :order_by_name, -> { order(name: :asc, price_cents: :desc) }
   scope :order_by_price, -> { order(price_cents: :desc) }
   scope :with_attend_rights, -> { where(can_attend: true) }
   scope :with_nomination_rights, -> { where(can_nominate: true) }
@@ -149,5 +149,4 @@ def price_increase(new_price, start_date, end_date = nil)
     self.active_to = new_record.active_from
     self.save
   end
-
 end

app/models/reservation.rb

@@ -23,6 +23,8 @@ class Reservation < ApplicationRecord
   include Holdable
   include Buyable
 
+  before_create :eval_for_upgrade_price_lock
+
   PAID = "paid"
   DISABLED = "disabled"
   INSTALMENT = "instalment"
@@ -94,6 +96,18 @@ def can_vote?
     Membership.can_vote.where(id: orders.select(:membership_id)).exists?
   end
 
+  def can_site_select?
+    Membership.can_site_select.where(id: orders.select(:membership_id)).exists?
+  end
+
+  def can_attend?
+    Membership.can_attend.where(id: orders.select(:membership_id)).exists?
+  end
+
+  def is_supporting?
+    self.can_nominate? && self.can_vote? && self.can_site_select? && !self.can_attend?
+  end
+
   def paid?
     state == PAID
   end
@@ -117,9 +131,32 @@ def disabled?
     state == DISABLED
   end
 
+  def date_upgrade_prices_locked
+    self.price_lock_date
+  end
+
+  def eval_for_upgrade_price_lock
+    return unless Rails.configuration.convention_details.lock_upgrade_prices_on_installment_req
+    return unless self.is_supporting?
+    return unless self.installment_requested_by_claimant?
+    return if self.price_lock_date?
+    set_price_lock_date
+  end
+
   # Sync when reservation changes as you might disable or enable rights on a reservation, or have it paid off
   after_commit :gloo_sync
   def gloo_lookup_user
     active_claim&.user
   end
+
+  def installment_requested_by_claimant?
+    return false unless self.active_claim.present?
+    self.active_claim.requested_installment?
+  end
+
+  private
+
+  def set_price_lock_date
+    self.update!(price_lock_date: Time.now)
+  end
 end

app/queries/non_pricelocked_reservations_with_installment_requests.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+# Copyright 2022 Victoria Garcia*
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+class NonPricelockedReservationsWithInstallmentRequests
+
+  def call
+    Reservation.joins(claims: :chicago_contact).where(chicago_contacts: {installment_wanted: true}, reservations: {price_lock_date: nil}, claims: {active_from: ..Time.now, active_to: [nil, Time.now..]}).select('reservations.id as id, chicago_contacts.created_at as new_price_lock_date') 
+  end
+end

app/queries/upgrade_offer.rb

@@ -20,24 +20,33 @@
 # Silver Fern upgrading to Adult cost $50 on CoNZealand launch ($375 - $325 = $50)
 # But when prices rotated, upgrading to Adult cost $75 ($400 - $325 = $75)
 class UpgradeOffer
-  attr_reader :from_membership, :to_membership
+  attr_reader :from_membership, :to_membership, :for_reservation, :target_membership
 
   delegate :description, to: :to_membership
 
-  def self.from(current_membership, target_membership: nil)
-    # List options that are higher price
+  def self.from(current_membership, target_membership: nil, for_reservation: nil)
+
+    # Get all the active options with a higher price than the current membership
     options = Membership.active.where("price_cents > ?", current_membership.price_cents)
+    initial_count = options.count
+
+    # Combine in any earlier (cheaper) Memberships the reservation holder has
+    # locked in.
+    options = self.include_locked_in_options(current_membership, for_reservation, options)
+
+    # We typically order by price, but if there are multiple price-points for
+    # a particular membership due to older prices being locked in, that can be
+    # confusing, and ordering by name is better.
 
-    # But don't let the name match, i.e. no upgrade adult to adult upgrade option
+    order_pricewise = initial_count >= options.count
+
+    # Don't duplicate the current membership, i.e. no offering to upgrade adult to adult
     options = options.where.not(name: current_membership.name)
 
     # If requested, only create offers for the target
     options = options.where(id: target_membership) if target_membership.present?
 
-    # Map matching memberships over the class and return as a list
-    options.order_by_price.map do |membership|
-      UpgradeOffer.new(from: current_membership, to: membership)
-    end
+    order_pricewise ? self.order_options_by_price(options, current_membership) : self.order_options_by_name(options, current_membership)
   end
 
   def initialize(from:, to:)
@@ -88,4 +97,28 @@ def price
   def offer_for_purchase?
     !to_membership.private_membership_option
   end
+
+  private
+
+  def self.include_locked_in_options(curr_membership, res_to_upgrade, existing_options)
+    unless (res_to_upgrade.present? && res_to_upgrade.date_upgrade_prices_locked.respond_to?(:strftime) )
+      return existing_options
+    end
+
+    locked_in_options = Membership.active_at(res_to_upgrade.date_upgrade_prices_locked).where("price_cents > ?", curr_membership.price_cents)
+
+    existing_options.or(locked_in_options)
+  end
+
+  def self.order_options_by_name(our_options, curr_membership)
+    our_options.order_by_name.map do |membership|
+      UpgradeOffer.new(from: curr_membership, to: membership)
+    end
+  end
+
+  def self.order_options_by_price(our_options, curr_membership)
+    our_options.order_by_price.map do |membership|
+      UpgradeOffer.new(from: curr_membership, to: membership)
+    end
+  end
 end

config/convention_details/convention.rb

@@ -43,6 +43,7 @@ class Convention
     class_attribute :con_wsfs_constitution_link
     class_attribute :con_year
     class_attribute :contact_model
+    class_attribute :lock_upgrade_prices_on_installment_req
     class_attribute :registration_mailing_address
     class_attribute :site_theme
     class_attribute :translation_folder

config/convention_details/worldcon80.rb

@@ -26,7 +26,7 @@ class Worldcon80 < ConventionDetails::Convention
                 :con_dates_informal_start, :con_greeting_basic, :con_hugo_download_A4, :con_hugo_download_letter,
                 :con_name_public, :con_name_public_previous, :con_number, :con_organizers_sigs, :hugo_administrator_sigs,
                 :con_url_homepage, :con_url_member_login, :con_url_privacy, :con_url_tos, :con_url_volunteering,
-                :con_wsfs_constitution_link, :con_year, :contact_model, :registration_mailing_address,
+                :con_wsfs_constitution_link, :con_year, :contact_model, :lock_upgrade_prices_on_installment_req, :registration_mailing_address,
                 :site_theme, :translation_folder
 
     def initialize
@@ -56,6 +56,12 @@ def initialize
       @con_wsfs_constitution_link = "http://www.wsfs.org/wp-content/uploads/2019/11/WSFS-Constitution-as-of-August-19-2019.pdf"
       @con_year = "2022"
       @contact_model = "chicago"
+      # If lock_upgrade_prices_on_installment_req is set to true,
+      # the price of upgrading a supporting membership will be
+      # locked to the current date if, while making the reservation,
+      # the user checks the box on the personal info form about
+      # being interested in paying in installments.
+      @lock_upgrade_prices_on_installment_req = true
       @registration_mailing_address = <<~ADDRESS
         Chicon 8 Member Services
         2020 N. California, Suite 299

db/migrate/20211220112953_add_price_lock_date_to_reservation.rb

@@ -0,0 +1,5 @@
+class AddPriceLockDateToReservation < ActiveRecord::Migration[6.1]
+  def change
+    add_column :reservations, :price_lock_date, :datetime
+  end
+end

db/seeds/chicago/development.seeds.rb

@@ -160,6 +160,14 @@
   FactoryBot.create(:cart, type, :paid, user: u)
 end
 
+
+claims_needing_installment_requests = Claim.last(10)
+claims_needing_installment_requests.each_with_index do |c, i|
+  c.contact.update_attribute(:installment_wanted, true)
+  puts "Added installment request \# #{i}"
+end
+
+
 puts ""
 puts "Membership total: #{Membership.all.count}"
 puts ""

db/structure.sql

@@ -662,7 +662,8 @@ CREATE TABLE public.reservations (
     state character varying NOT NULL,
     membership_number integer NOT NULL,
     ballot_last_mailed_at timestamp without time zone,
-    last_fully_paid_membership_id bigint
+    last_fully_paid_membership_id bigint,
+    price_lock_date timestamp without time zone
 );
 
 
@@ -1548,6 +1549,7 @@ INSERT INTO "schema_migrations" (version) VALUES
 ('20210916230829'),
 ('20211110022812'),
 ('20211120232041'),
+('20211220112953'),
 ('20220116010218'),
 ('20220130232402');
 

lib/tasks/data.rake

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+# Copyright 2022 Victoria Garcia*
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# Adapted from
+# https://www.ombulabs.com/blog/rails/data-migrations/three-useful-data-migrations-patterns-in-rails.html
+
+namespace :data_migration do
+
+  desc "Assigns a price_lock_date to Reservation instances where both (a) that field is currently set to nil, and (b) The associated Contact instance has its installment_wanted field set to 'true'"
+
+  task :backdate_reservation_price_lock_dates => :environment do
+    puts "\n Preparing to update any reservations that qualify for backdated price lock dates. \n"
+    PriceLockBackdater.new.call
+    puts "\n Price lock date backdating process completed.\n"
+  end
+end