Added checks for MaxRecursion #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragusaa
force-pushed
the
CLAM-2602-ValidateMaxRecursion
branch
from
2b09e8a to
324d06b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
micahsnyder
requested changes
May 7, 2024
ragusaa
force-pushed
the
CLAM-2602-ValidateMaxRecursion
branch
4 times, most recently
from
fbfedaf to
4c9709a
Compare
ragusaa
force-pushed
the
CLAM-2602-ValidateMaxRecursion
branch
3 times, most recently
from
ac78ae8 to
c866085
Compare
There is presently no limit for the max-recursion scan option. Selecting a max-recursion limit that is too high will cause confusing errors. E.g.: /home/aragusa/install.alz/bin/clamscan -d clamav.hdb . --max-recursion=9999999999 LibClamAV Error: fmap_fd: Attempted to get fd for NULL fmap /home/aragusa/issue/clamav.hdb: Can't allocate memory ERROR LibClamAV Error: fmap_fd: Attempted to get fd for NULL fmap /home/aragusa/issue/test.sh: Can't allocate memory ERROR This commit prevents setting the max-recursion limit higher than 100.
micahsnyder
force-pushed
the
CLAM-2602-ValidateMaxRecursion
branch
from
c866085 to
29987c0
Compare
micahsnyder
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets a limit on the max-recursion config option. Users will no longer be able to set max-recursion higher than 100.
Setting max-recursion to high may memory allocation errors on startup and attempting to scan a file with too many layers of recursion may cause a stack overflow crash.