Fix CVD dsig verification when hash starts with zeros #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally the MD5 hash for RSA-based digital signature verification begins with zeros. A bug in how we convert the RSA decoded plain text from a big number back to a hex string causes it to write the number to the far left of the plain text buffer. If the number is smaller than a hash, then zero-padding ends up on the right when it should've been on the left. Additional fix: BN_bn2bin() will write zero bytes if the bignum is 0. So there is no point "error checking" the BN_bn2bin() call. Thanks to Tom Judge for noticing these shenanigans. Ref: openssl/openssl#2101 Side note: BN_num_bytes() will also return 0 if the bignum is 0, which is fine.
micahsnyder
force-pushed
the
CLAM-2628-Fix-CVD-dsig-verification-when-hash-starts-with-zero
branch
from
2bb3f13 to
b8795fd
Compare
tj-cisco
previously approved these changes
Dec 4, 2024
|
Per discussion with @TheRaynMan and @tj-cisco will add a retry in case the md5 for signing has the 00 prefix. That way new sigtool doesn't make CVD's that fail to verify on older clamav. |
Have --build retry if the tar.gz MD5 starts with 00.
micahsnyder
force-pushed
the
CLAM-2628-Fix-CVD-dsig-verification-when-hash-starts-with-zero
branch
from
46cfc0a to
4d389f3
Compare
rsundriyal
approved these changes
Jan 10, 2025
micahsnyder
deleted the
CLAM-2628-Fix-CVD-dsig-verification-when-hash-starts-with-zero
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally the MD5 hash for RSA-based digital signature verification begins with zeros. A bug in how we convert the RSA decoded plain text from a big number back to a hex string causes it to write the number to the far left of the plain text buffer. If the number is smaller than a hash, then zero-padding ends up on the right when it should've been on the left.