Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClamOnAcc: Fix infinite loop when OnAccessIncludePath doesn't exist (1.0.8) #1426

Merged

Conversation

micahsnyder
Copy link
Contributor

Backport of #1047 for 1.0.8

@micahsnyder
Copy link
Contributor Author

@opoplawski

@opoplawski
Copy link
Contributor

Thank you! Any ETA for a 1.0.8 release?

@micahsnyder
Copy link
Contributor Author

January 22.

@rsundriyal rsundriyal self-requested a review January 10, 2025 15:45
rsundriyal
rsundriyal previously approved these changes Jan 10, 2025
Upgrade macOS OpenSSL dependency to use 3 instead of 1.1.

Python's pip from Homebrew now refuses to isntall globally:

error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try brew install
    xyz, where xyz is the package you are trying to
    install.

    If you wish to install a Python library that isn't in Homebrew,
    use a virtual environment:

    python3 -m venv path/to/venv
    source path/to/venv/bin/activate
    python3 -m pip install xyz

    If you wish to install a Python application that isn't in Homebrew,
    it may be easiest to use 'pipx install xyz', which will manage a
    virtual environment for you. You can install pipx with

    brew install pipx

    You may restore the old behavior of pip by passing
    the '--break-system-packages' flag to pip, or by adding
    'break-system-packages = true' to your pip.conf file. The latter
    will permanently disable this error.

    If you disable this error, we STRONGLY recommend that you additionally
    pass the '--user' flag to pip, or set 'user = true' in your pip.conf
    file. Failure to do this can result in a broken Homebrew installation.

    Read more about this behavior here: <https://peps.python.org/pep-0668/>

Using Pipx instead. Making the same change for Ubuntu just in case.
@micahsnyder
Copy link
Contributor Author

micahsnyder commented Jan 12, 2025

Added a cherry-pick of fa10d0c to fix the failed mac CI build.

@rsundriyal rsundriyal self-requested a review January 13, 2025 13:33
@micahsnyder micahsnyder merged commit 8b02662 into Cisco-Talos:dev/1.0.8 Jan 13, 2025
22 of 24 checks passed
@micahsnyder micahsnyder deleted the CLAM-2216-ClamOnAccLoop-1.0.8 branch January 13, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants