feat: Improve version checking for cvdupdate package #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of pkg_resources is deprecated in favor of importlib.resources, importlib.metadata and their backports (importlib_resources, importlib_metadata). refactor: Reorder of imports to improve readability.
Retrieve the latest cvdupdate package version directly from PyPI using the JSON API (`https://pypi.org/pypi/cvdupdate/json`) for more robust and accurate comparisons. This change also removes the dependency on the deprecated `pkg_resources` module, replacing it with the recommended `importlib.metadata` module. This change also reorders the imports to improve readability. These improvements enhance the reliability of version checking and ensure compatibility with future Python releases.
micahsnyder
approved these changes
Jan 3, 2025
|
@steve-mays Our org mandated commit signing so I'm unable to merge it as-is. Would you like to sign the commits? Alternatively, I can do it for you. I wanted to ask before I did so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adressess #66.
Retrieve the latest cvdupdate package version directly from PyPI using
the JSON API (
https://pypi.org/pypi/cvdupdate/json) for more robustand accurate comparisons.
This change also removes the dependency on the deprecated
pkg_resourcesmodule, replacing it with the recommendedimportlib.metadatamodule.This change also reorders the imports to improve readability.
These improvements enhance the reliability of version checking and
ensure compatibility with future Python releases.