Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SectionNavigation Component Creation #282

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

SectionNavigation Component Creation #282

wants to merge 15 commits into from

Conversation

sreidthomas
Copy link
Contributor

@sreidthomas sreidthomas commented Jan 17, 2025 •
edited
Loading

More Information Coming Soon

Mobile

Image

Image

Image

Desktop

Image

Image

2025-01-17.09-49-48.mp4

TEST RESULTS:

image

@sreidthomas sreidthomas changed the title Section Navigation Component SectionNavigation Component Creation Jan 17, 2025
maxatdetroit
maxatdetroit requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@maxatdetroit maxatdetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is already approx. 5 million times better than our experimental components. You're doing a fantastic job applying best practices. I added some comments here to take it to an even higher level of perfection.

src/stable/components/organisms/SectionNavigation/SectionNavigation.js Outdated Show resolved Hide resolved
src/stable/components/organisms/SectionNavigation/SectionNavigation.js Outdated Show resolved Hide resolved
src/stable/components/organisms/SectionNavigation/SectionNavigation.css Outdated Show resolved Hide resolved
src/stable/components/organisms/SectionNavigation/SectionNavigation.css Outdated Show resolved Hide resolved
src/stable/components/organisms/SectionNavigation/SectionNavigation.js Outdated Show resolved Hide resolved
src/stable/stories/sectionnavigation.stories.js Show resolved Hide resolved
src/stable/components/organisms/SectionNavigation/SectionNavigation.css Outdated Show resolved Hide resolved
@maxatdetroit maxatdetroit linked an issue Feb 3, 2025 that may be closed by this pull request
Create section navigation component for skip links #277
Open
@maxatdetroit maxatdetroit mentioned this pull request Feb 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedgar1mx jedgar1mx Awaiting requested review from jedgar1mx

@maxatdetroit maxatdetroit Awaiting requested review from maxatdetroit

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create section navigation component for skip links
2 participants
@sreidthomas @maxatdetroit