Add Bluesky social link #275
Conversation
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
|
Visit the preview URL for this PR (updated for commit 484121a): https://ca-it-prod-home-5918--pr275-homer-itsm-1163-blue-9y68crtu.web.app (expires Wed, 11 Dec 2024 20:21:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a4e81efe93bc3b3031a6519079cfd86123032bee |
|
Git is dumb. My changes to data.js didn't properly commit. Hold on this until new commit is pushed |
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
|
Additional Info |
|
If you have bandwidth, can you review @dmundra? |
There was a problem hiding this comment.
Looks good for the most part. A nitpick I noticed on Chrome+Mac the Bluesky and Twitter icons bottom curve is higher than Vimeo and LinkedIn. Not sure why that is happening as I can see the values of the images are the same. Screenshot using a random Mac window as a ruler to see those differences:
|
Thank you @dmundra for catching that. I'll update the SVG. I had to create the icon from scratch, so my sizes seem to be a little off. I'll get that updated and push a hotfix once it is done. Thank you again! |
|
@TheBoatyMcBoatFace Small nit (maybe intentional?): the footer Vimeo, Bluesky and Linkedin icons become blue on mouse-over, but the X/Twitter icon does not. |
Added Bluesky footer links. I can't figure out how to get the local preview env setup, so I haven't been able to confirm that this works. The only part I am worried about is the icon style.